Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: client/cros/cros_ui_test.py

Issue 6880182: Ensure crashes are copied out before cryptohome is wiped. (Closed) Base URL: ssh://gitrw.chromium.org:9222/autotest.git@master
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cros/cros_ui_test.py
diff --git a/client/cros/cros_ui_test.py b/client/cros/cros_ui_test.py
index d05c2fcb3af65c9dbf7f08cdd72a890752384a3d..9c92d1f4ac342846162416aed67b8e2d906fe45c 100644
--- a/client/cros/cros_ui_test.py
+++ b/client/cros/cros_ui_test.py
@@ -89,7 +89,7 @@ class UITest(test.test):
logging.debug("Stored %s for %s" % (self._dns[path],
interface))
ipconfig.SetProperty('NameServers', '127.0.0.1')
- logging.debug("Using local DNS for " + interface)
+ logging.debug("Using local DNS for " + interface)
utils.poll_for_condition(
lambda: self.__attempt_resolve('www.google.com', '127.0.0.1'),
@@ -109,7 +109,7 @@ class UITest(test.test):
if path in self._dns:
ipconfig = self._flim.GetObjectInterface('IPConfig', path)
ipconfig.SetProperty('NameServers', self._dns[path])
- logging.debug("Reverted DNS for " + interface)
+ logging.debug("Reverted DNS for " + interface)
else:
logging.debug("No stored DNS for " + interface)
@@ -369,7 +369,11 @@ class UITest(test.test):
shutil.copy(
os.path.join(constants.CRYPTOHOME_MOUNT_PT,
'log', 'chrome'),
- self.resultsdir+'/chrome_postlogin_log')
+ os.path.join(self.resultsdir, 'chrome_postlogin_log'))
+ # Retrieve any cores left by crashes during testing.
+ shutil.copytree(
+ os.path.join(constants.CRYPTOHOME_MOUNT_PT, 'crash'),
+ os.path.join(self.resultsdir, 'crashes'))
except (IOError, OSError) as err:
logging.error(err)
self.logout()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698