Ensure crashes are copied out before cryptohome is wiped.

client/cros/cros_ui_test.py

 # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import dbus, logging, os, re, shutil, socket, sys
 import common
 import auth_server, constants, cryptohome, dns_server
 import cros_logging, cros_ui, login, ownership
 from autotest_lib.client.bin import test, utils
 from autotest_lib.client.common_lib import error
@@ skipping 71 matching lines @@
             logging.debug("Considering " + interface)
             for path in properties['IPConfigs']:
                 ipconfig = self._flim.GetObjectInterface('IPConfig', path)
 
                 servers = ipconfig.GetProperties().get('NameServers', None)
                 if servers != None:
                     self._dns[path] = ','.join(servers)
                     logging.debug("Stored %s for %s" % (self._dns[path],
                                                         interface))
                 ipconfig.SetProperty('NameServers', '127.0.0.1')
-                logging.debug("Using local DNS for "  + interface)
+                logging.debug("Using local DNS for " + interface)
 
         utils.poll_for_condition(
             lambda: self.__attempt_resolve('www.google.com', '127.0.0.1'),
             login.TimeoutError('Timed out waiting for DNS changes.'),
             10)
 
 
     def revert_dns(self):
         """Clear the custom DNS setting for all devices and force them to use
         DHCP to pull the network's real settings again.
         """
         for device in self._flim.GetObjectList('Device'):
             properties = device.GetProperties()
             interface = properties['Interface']
             logging.debug("Considering " + interface)
             for path in properties['IPConfigs']:
                 if path in self._dns:
                     ipconfig = self._flim.GetObjectInterface('IPConfig', path)
                     ipconfig.SetProperty('NameServers', self._dns[path])
-                    logging.debug("Reverted DNS for "  + interface)
+                    logging.debug("Reverted DNS for " + interface)
                 else:
                     logging.debug("No stored DNS for " + interface)
 
         utils.poll_for_condition(
             lambda: self.__attempt_resolve('www.google.com',
                                            '127.0.0.1',
                                            expected=False),
             login.TimeoutError('Timed out waiting to revert DNS.'),
             10)
 
@@ skipping 239 matching lines @@
                                                        filename))
 
         except (IOError, OSError) as err:
             logging.error(err)
 
         if login.logged_in():
             try:
                 shutil.copy(
                     os.path.join(constants.CRYPTOHOME_MOUNT_PT,
                                  'log', 'chrome'),
-                    self.resultsdir+'/chrome_postlogin_log')
+                    os.path.join(self.resultsdir, 'chrome_postlogin_log'))
+                # Retrieve any cores left by crashes during testing.
+                shutil.copytree(
+                    os.path.join(constants.CRYPTOHOME_MOUNT_PT, 'crash'),
+                    os.path.join(self.resultsdir, 'crashes'))
             except (IOError, OSError) as err:
                 logging.error(err)
             self.logout()
 
         if os.path.isfile(constants.CRYPTOHOMED_LOG):
             try:
                 base = os.path.basename(constants.CRYPTOHOMED_LOG)
                 shutil.copy(constants.CRYPTOHOMED_LOG,
                             os.path.join(self.resultsdir, base))
             except (IOError, OSError) as err:
                 logging.error(err)
 
         if self.fake_owner:
             logging.info('Erasing fake owner state.')
             ownership.clear_ownership()
 
         self.stop_authserver()
         self.__log_crashed_processes(self.crash_blacklist)
 
 
     def get_auth_endpoint_misses(self):
         if hasattr(self, '_authServer'):
             return self._authServer.get_endpoint_misses()
         else:
             return {}