Issue 6880178: Merge 82672 - GTK: Fix valgrind errors in previous wmclass patch.(Can't actually read that field;...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6880178: Merge 82672 - GTK: Fix valgrind errors in previous wmclass patch.(Can't actually read that field;... (Closed)

Created:
9 years, 8 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
erg

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/742/src/

Visibility:
Public.

Merge 82672 - GTK: Fix valgrind errors in previous wmclass patch.(Can't actually read that field; need to use the glib accessor.)BUG=80282, 20587 TEST=valgrind goes green.Review URL: http://codereview.chromium.org/6896028 TBR=erg@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82901

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/gtk/browser_window_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)