Issue 6896028: GTK: Fix valgrind errors in previous wmclass patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6896028: GTK: Fix valgrind errors in previous wmclass patch. (Closed)

Created:
9 years, 8 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

GTK: Fix valgrind errors in previous wmclass patch. (Can't actually read that field; need to use the glib accessor.) BUG=80282, 20587 TEST=valgrind goes green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82672

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -20 lines)			Patch
	M	chrome/browser/ui/gtk/browser_window_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download

Total messages: 4 (0 generated)

Elliot Glaysher

FYI, I'm forcing this but I get the following messages on a git cl dcommit: ...

9 years, 8 months ago (2011-04-22 18:15:04 UTC) #3

LGTM