Add two libcros interfaces for handwriting: SendHandwritingStrokes and CancelHandwriting.

Add two libcros interfaces for handwriting: SendHandwritingStrokes and CancelHandwriting.

BUG=chromium-os:14421
TEST=ran emerge

Change-Id: I287abd4d02299cc724f6fd8b9a36c7fc4276f0b0

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=64ecf8b

[Zachary Kuznia, 2011-04-27 09:45:45]

http://codereview.chromium.org/6880171/diff/7001/chromeos_input_method.cc
File chromeos_input_method.cc (right):

http://codereview.chromium.org/6880171/diff/7001/chromeos_input_method.cc#new...
chromeos_input_method.cc:657: LOG(WARNING) << "Empty stroke data or a single dot
is passed.";
I think VLOG is preferred now.

http://codereview.chromium.org/6880171/diff/7001/load.cc
File load.cc (right):

http://codereview.chromium.org/6880171/diff/7001/load.cc#newcode8
load.cc:8: #include <utility>
I don't think you need this here.

[Yusuke Sato, 2011-04-27 10:10:32]

http://codereview.chromium.org/6880171/diff/7001/chromeos_input_method.cc
File chromeos_input_method.cc (right):

http://codereview.chromium.org/6880171/diff/7001/chromeos_input_method.cc#new...
chromeos_input_method.cc:657: LOG(WARNING) << "Empty stroke data or a single dot
is passed.";
On 2011/04/27 09:45:46, Zachary Kuznia wrote:
> I think VLOG is preferred now.

It seems that VLOG is not supported in the logging library for ChromeOS. So let
me keep the line as-is.

http://codereview.chromium.org/6880171/diff/7001/load.cc
File load.cc (right):

http://codereview.chromium.org/6880171/diff/7001/load.cc#newcode8
load.cc:8: #include <utility>
On 2011/04/27 09:45:46, Zachary Kuznia wrote:
> I don't think you need this here.

Done.

[Zachary Kuznia, 2011-04-27 10:18:42]

LGTM

On Wed, Apr 27, 2011 at 7:10 PM, <yusukes@chromium.org> wrote:

>
> http://codereview.chromium.org/6880171/diff/7001/chromeos_input_method.cc
> File chromeos_input_method.cc (right):
>
>
>
http://codereview.chromium.org/6880171/diff/7001/chromeos_input_method.cc#new...
> chromeos_input_method.cc:657: LOG(WARNING) << "Empty stroke data or a
> single dot is passed.";
> On 2011/04/27 09:45:46, Zachary Kuznia wrote:
>
>> I think VLOG is preferred now.
>>
>
> It seems that VLOG is not supported in the logging library for ChromeOS.
> So let me keep the line as-is.
>
>
> http://codereview.chromium.org/6880171/diff/7001/load.cc
> File load.cc (right):
>
> http://codereview.chromium.org/6880171/diff/7001/load.cc#newcode8
> load.cc:8: #include <utility>
> On 2011/04/27 09:45:46, Zachary Kuznia wrote:
>
>> I don't think you need this here.
>>
>
> Done.
>
>
> http://codereview.chromium.org/6880171/
>

[Peng, 2011-04-27 14:23:11]

LGTM

http://codereview.chromium.org/6880171/diff/9006/chromeos_input_method.cc
File chromeos_input_method.cc (right):

http://codereview.chromium.org/6880171/diff/9006/chromeos_input_method.cc#new...
chromeos_input_method.cc:666: const size_t raw_strokes_size = strokes.size() *
2;
Maybe we could use ((double*)&strokes[0]) and avoid an additional copy here.

http://stackoverflow.com/questions/2923272/how-to-convert-vector-to-array-c

[Yusuke Sato, 2011-05-02 05:22:26]

http://codereview.chromium.org/6880171/diff/9006/chromeos_input_method.cc
File chromeos_input_method.cc (right):

http://codereview.chromium.org/6880171/diff/9006/chromeos_input_method.cc#new...
chromeos_input_method.cc:666: const size_t raw_strokes_size = strokes.size() *
2;
I know it's safe to use the internal buffer of std::vector as C array, but what
about std::pair? The variable is not a vector<double> but
vector<pair<double,double> >, and as far as I know the C++ standard does not
guarantee that std::pair's layout is always compatible with C struct. To avoid
unexpected behavior in the future, let me keep the current code.

On 2011/04/27 14:23:11, Peng wrote:
> Maybe we could use ((double*)&strokes[0]) and avoid an additional copy here.
> 
> http://stackoverflow.com/questions/2923272/how-to-convert-vector-to-array-c
>

[Peng, 2011-05-02 14:11:47]

http://codereview.chromium.org/6880171/diff/9006/chromeos_input_method.cc
File chromeos_input_method.cc (right):

http://codereview.chromium.org/6880171/diff/9006/chromeos_input_method.cc#new...
chromeos_input_method.cc:666: const size_t raw_strokes_size = strokes.size() *
2;
On 2011/05/02 05:22:26, Yusuke Sato wrote:
> I know it's safe to use the internal buffer of std::vector as C array, but
what
> about std::pair? The variable is not a vector<double> but
> vector<pair<double,double> >, and as far as I know the C++ standard does not
> guarantee that std::pair's layout is always compatible with C struct. To avoid
> unexpected behavior in the future, let me keep the current code.
> 
> On 2011/04/27 14:23:11, Peng wrote:
> > Maybe we could use ((double*)&strokes[0]) and avoid an additional copy here.
> > 
> > http://stackoverflow.com/questions/2923272/how-to-convert-vector-to-array-c
> > 
> 

Yeah. It needs change pair to double or double[2] to make it safer.