ipc/ipc_sync_channel.cc - Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_sync_channel.cc

Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/ (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Static casting to DWORD to fix type mismatch Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_sync_channel.cc

diff --git a/ipc/ipc_sync_channel.cc b/ipc/ipc_sync_channel.cc

index 5cc4729732e697046e9b3e2b83a7ebfba830ee6b..97e1c18d3e979ec36cf031ffcaa5f63a77fe47e7 100644

--- a/ipc/ipc_sync_channel.cc

+++ b/ipc/ipc_sync_channel.cc

@@ -361,7 +361,7 @@ void SyncChannel::SyncContext::OnWaitableEventSignaled(WaitableEvent* event) {

CancelPendingSends();

} else {

// We got the reply, timed out or the process shutdown.

- DCHECK(event == GetSendDoneEvent());

+ DCHECK_EQ(GetSendDoneEvent(), event);

MessageLoop::current()->QuitNow();

}

« no previous file with comments | « ipc/ipc_channel_win.cc ('k') | ipc/ipc_sync_message_unittest.cc » ('j') | no next file with comments »