ipc/ipc_channel_win.cc - Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_win.cc

Issue 6880166: Improving logging in /app, /base, /crypto and /ipc. Updating plain DCHECK() usages for DCHECK_EQ/LE/ (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Static casting to DWORD to fix type mismatch Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_win.cc

diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc

index 9182200d440b7f13bed7fc0c874e3b1bbeb7ce9e..be929b12710b2aa709c73258d5ce96a934b03dfd 100644

--- a/ipc/ipc_channel_win.cc

+++ b/ipc/ipc_channel_win.cc

@@ -177,7 +177,7 @@ const std::wstring Channel::ChannelImpl::PipeName(

bool Channel::ChannelImpl::CreatePipe(const IPC::ChannelHandle &channel_handle,

Mode mode) {

- DCHECK(pipe_ == INVALID_HANDLE_VALUE);

+ DCHECK_EQ(INVALID_HANDLE_VALUE, pipe_);

const std::wstring pipe_name = PipeName(channel_handle.name);

if (mode & MODE_SERVER_FLAG) {

SECURITY_ATTRIBUTES security_attributes = {0};

« no previous file with comments | « crypto/signature_verifier_win.cc ('k') | ipc/ipc_sync_channel.cc » ('j') | no next file with comments »