Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 6878089: Add and use a base::i18n::StringWithDirection for carrying titles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review feedback Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/i18n/rtl.h ('K') | « content/browser/tab_contents/tab_contents.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index 8bcc8e43422b8bb908dcfd6b3265ed9935583574..d4f871be051cc04c7f71b04de81cd5a5b0e4cc11 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -1992,8 +1992,7 @@ void TabContents::UpdateState(RenderViewHost* rvh,
void TabContents::UpdateTitle(RenderViewHost* rvh,
int32 page_id,
- const string16& title,
- WebKit::WebTextDirection title_direction) {
+ const base::i18n::String16WithDirection& title) {
// If we have a title, that's a pretty good indication that we've started
// getting useful data.
SetNotWaitingForResponse();
@@ -2003,7 +2002,7 @@ void TabContents::UpdateTitle(RenderViewHost* rvh,
page_id);
// TODO(evan): use directionality of title.
// http://code.google.com/p/chromium/issues/detail?id=27094
- if (!entry || !UpdateTitleForEntry(entry, UTF16ToWide(title)))
+ if (!entry || !UpdateTitleForEntry(entry, UTF16ToWide(title.string())))
return;
// Broadcast notifications when the UI should be updated.
« base/i18n/rtl.h ('K') | « content/browser/tab_contents/tab_contents.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698