Issue 6877053: Base: More adjustments to BASE_API and project dependencies to

Issue 6877053: Base: More adjustments to BASE_API and project dependencies to (Closed)

Created:
9 years, 8 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Base: More adjustments to BASE_API and project dependencies to use base.dll from chrome. BUG=76996 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82564

Patch Set 2 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -43 lines)			Patch
M	base/base.gyp	View	1	3 chunks	+7 lines, -1 line	0 comments	Download
M	base/base.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	base/bzip2_error_handler.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	base/debug/profiler.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	base/files/file_path_watcher.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/logging.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_loop.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/metrics/nacl_histogram.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	base/string_util.h	View	1	2 chunks	+10 lines, -11 lines	0 comments	Download
M	base/tracked_objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/utf_offset_string_conversions.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/utf_string_conversion_utils.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/app/policy/cloud_policy_codegen.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_loader_win.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_installer_util.gypi	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/common/bzip2_error_handler.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/default_plugin/default_plugin.gyp	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/installer/upgrade_test.gyp	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/6877053/diff/1/base/string_util_static.h File base/string_util_static.h (right): http://codereview.chromium.org/6877053/diff/1/base/string_util_static.h#newcode5 base/string_util_static.h:5: #ifndef BASE_STRING_UTIL_STATIC_H_ Why is this file necessary? It seems ...

9 years, 8 months ago (2011-04-20 16:03:41 UTC) #2

rvargas (doing something else)

Thanks. Please take another look. http://codereview.chromium.org/6877053/diff/1/base/string_util_static.h File base/string_util_static.h (right): http://codereview.chromium.org/6877053/diff/1/base/string_util_static.h#newcode5 base/string_util_static.h:5: #ifndef BASE_STRING_UTIL_STATIC_H_ On 2011/04/20 ...

9 years, 8 months ago (2011-04-20 21:23:58 UTC) #3

LGTM

Expand Messages | Collapse Messages