Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3874)

Unified Diff: base/base.gyp

Issue 6877053: Base: More adjustments to BASE_API and project dependencies to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
===================================================================
--- base/base.gyp (revision 82052)
+++ base/base.gyp (working copy)
@@ -55,7 +55,8 @@
},
{
# This is the subset of files from base that should not be used with a
- # dynamic library.
+ # dynamic library. Note that this library cannot depend on base because
+ # base depends on base_static.
'target_name': 'base_static',
'type': '<(library)',
'sources': [
@@ -220,6 +221,7 @@
'base_i18n',
'base_static',
'test_support_base',
+ 'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'../testing/gmock.gyp:gmock',
'../testing/gtest.gyp:gtest',
],
@@ -278,10 +280,14 @@
'type': '<(library)',
'dependencies': [
'base',
+ 'base_static',
'base_i18n',
'../testing/gmock.gyp:gmock',
'../testing/gtest.gyp:gtest',
],
+ 'export_dependent_settings': [
+ 'base',
+ ],
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd"', {
'dependencies': [
« no previous file with comments | « no previous file | base/base.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698