Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 6874038: Remove the last Chrome dependencies from renderer, and enforce no more includes through DEPS. I ... (Closed)

Created:
9 years, 8 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Remove the last Chrome dependencies from renderer, and enforce no more includes through DEPS. I also added DEPS checking for gpu/plugin/worker directories as well. I moved the Chrome specific browser tests to the chrome directory, and removed render_widget_unittest since it didn't seem to be testing much (there are tests that test it much more fully). I had to move bindings_policy.h, which ideally would be split into separate pieces so that the content layer only has to know about the content bindings. Given that it's basically an enum, I moved the whole file now since it's used in a lot of places, and the value of turning on DEPS checking is really high. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81924

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1132 lines, -1230 lines) Patch
M chrome/browser/chromeos/login/web_page_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/desktop_notification_handler.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/enterprise_enrollment_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_html_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 4 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
D chrome/common/bindings_policy.h View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 5 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 5 chunks +0 lines, -22 lines 0 comments Download
D chrome/common/prerender_constants.h View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 11 chunks +0 lines, -63 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 2 chunks +2 lines, -28 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 chunks +0 lines, -24 lines 0 comments Download
A chrome/renderer/autofill/autofill_browsertest.cc View 1 chunk +161 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 5 chunks +21 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 2 5 chunks +68 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 7 chunks +257 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 1 2 3 4 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 2 4 chunks +14 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/external_extension.cc View 1 2 3 chunks +19 lines, -3 lines 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/renderer/print_web_view_helper_browsertest.cc View 1 chunk +203 lines, -0 lines 0 comments Download
M chrome/renderer/translate_helper_browsertest.cc View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M content/browser/child_process_security_policy.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 6 chunks +11 lines, -6 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 1 chunk +0 lines, -3 lines 2 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 5 chunks +1 line, -5 lines 0 comments Download
M content/browser/webui/web_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/common/bindings_policy.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/content_constants.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/common/content_constants.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/content_switches.h View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M content/common/content_switches.cc View 1 2 5 chunks +22 lines, -0 lines 0 comments Download
A content/common/url_constants.h View 1 chunk +49 lines, -0 lines 0 comments Download
A content/common/url_constants.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 chunks +55 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/gpu/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M content/renderer/content_renderer_client.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/content_renderer_client.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/navigation_state.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/notification_provider.cc View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/render_thread.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view.h View 1 2 26 chunks +24 lines, -124 lines 0 comments Download
M content/renderer/render_view.cc View 1 2 42 chunks +16 lines, -318 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 3 chunks +0 lines, -410 lines 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_observer.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
D content/renderer/render_widget_unittest.cc View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
M content/worker/DEPS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/worker/worker_uitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
the checkdeps failure is expected since this depends on http://codereview.chromium.org/6873040/ and http://codereview.chromium.org/6869051/
9 years, 8 months ago (2011-04-18 03:31:00 UTC) #1
Avi (use Gerrit)
LGTM http://codereview.chromium.org/6874038/diff/7041/content/browser/tab_contents/tab_contents.h File content/browser/tab_contents/tab_contents.h (left): http://codereview.chromium.org/6874038/diff/7041/content/browser/tab_contents/tab_contents.h#oldcode1008 content/browser/tab_contents/tab_contents.h:1008: bool dont_notify_render_view_; Have you verified that this is ...
9 years, 8 months ago (2011-04-18 04:44:11 UTC) #2
jam
http://codereview.chromium.org/6874038/diff/7041/content/browser/tab_contents/tab_contents.h File content/browser/tab_contents/tab_contents.h (left): http://codereview.chromium.org/6874038/diff/7041/content/browser/tab_contents/tab_contents.h#oldcode1008 content/browser/tab_contents/tab_contents.h:1008: bool dont_notify_render_view_; On 2011/04/18 04:44:11, Avi wrote: > Have ...
9 years, 8 months ago (2011-04-18 04:53:55 UTC) #3
Avi (use Gerrit)
9 years, 8 months ago (2011-04-18 13:21:38 UTC) #4
SGTM

On Mon, Apr 18, 2011 at 12:53 AM, <jam@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/6874038/diff/7041/content/browser/tab_contents...
> File content/browser/tab_contents/tab_contents.h (left):
>
>
>
http://codereview.chromium.org/6874038/diff/7041/content/browser/tab_contents...
> content/browser/tab_contents/tab_contents.h:1008: bool
> dont_notify_render_view_;
> On 2011/04/18 04:44:11, Avi wrote:
>
>> Have you verified that this is no longer needed?
>>
>
> it's used to control whether or not to send an IPC to the renderer,
> which even if sent, toggles a member variable in RV that's not used
>
>
> http://codereview.chromium.org/6874038/
>

Powered by Google App Engine
This is Rietveld 408576698