Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: content/renderer/notification_provider.cc

Issue 6874038: Remove the last Chrome dependencies from renderer, and enforce no more includes through DEPS. I ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/notification_provider.cc
===================================================================
--- content/renderer/notification_provider.cc (revision 81920)
+++ content/renderer/notification_provider.cc (working copy)
@@ -6,8 +6,6 @@
#include "base/string_util.h"
#include "base/task.h"
-#include "chrome/common/url_constants.h"
-#include "chrome/common/render_messages.h"
#include "content/common/desktop_notification_messages.h"
#include "content/common/view_messages.h"
#include "content/renderer/render_thread.h"
@@ -102,15 +100,6 @@
bool NotificationProvider::ShowHTML(const WebNotification& notification,
int id) {
- // Disallow HTML notifications from unwanted schemes. javascript:
- // in particular allows unwanted cross-domain access.
- GURL url = notification.url();
- if (!url.SchemeIs(chrome::kHttpScheme) &&
- !url.SchemeIs(chrome::kHttpsScheme) &&
- !url.SchemeIs(chrome::kExtensionScheme) &&
- !url.SchemeIs(chrome::kDataScheme))
- return false;
-
DCHECK(notification.isHTML());
DesktopNotificationHostMsg_Show_Params params;
params.origin =

Powered by Google App Engine
This is Rietveld 408576698