Extend PathService::Get to be able to return the X86 program files path.

Extend PathService::Get to be able to return the X86 program files path.

Cloud print's virtual driver needs this to be able to find the Chrome install directory.  Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly.


BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82686

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82891

[Scott Byer, 2011-04-21 21:23:23]

LGTM

On 2011/04/21 18:49:11, Albert Bodenhamer wrote:

[Albert Bodenhamer, 2011-04-21 21:54:01]

Adding Mark for OWNERS approval.

[Mark Mentovai, 2011-04-21 22:33:23]

LGTM

[Albert Bodenhamer, 2011-04-22 17:33:48]

I need some advice on this CL.

I originally committed it yesterday afternoon and the builder broke with: 
http://build.chromium.org/p/chromium/builders/Win/builds/3804/steps/compile/l...

Mine was the only CL on the blame list so the sheriff reverted.

I don't see how this change could have caused the break though.  A full local
sync and rebuild last night ran fine and a fresh set of tries this morning are
happy so far (still waiting on one).

Do you think I should keep digging or should I just resubmit once all of my
tries complete?

[commit-bot: I haz the power, 2011-04-22 19:28:22]

Change committed as 82686

[Albert Bodenhamer, 2011-04-22 22:56:36]

First the good news:
As I suspected, this change ISN'T responsible for the build break it was
originally rolled back for.

The bad news:
CSIDL_PROGRAM_FILESX86 doesn't work on 32 bit (at least not on XP) resulting in
a broken unit test on XP.  The CL was rolled back again.

I've restructured it so that if it detects a 32 bit system it will fall through
to the DIR_PROGRAM_FILES case.  That will give the results we expect.  I've
tested on XP in hive and it works properly.  I've started a new set of tries as
well.

Can you guys take another quick look?  I'd like to try again on Monday.

Thanks.

[commit-bot: I haz the power, 2011-04-25 18:03:14]

Change committed as 82891