Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: cloud_print/virtual_driver/win/port_monitor/port_monitor.cc

Issue 6873159: Extend PathService::Get to be able to return the X86 program files path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix broken unit test on 32 bit systems. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_paths_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/virtual_driver/win/port_monitor/port_monitor.cc
diff --git a/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc b/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc
index 5141f99615b32da64d945c929db0289285aed41b..cd54d2a3c40fc44038c26762451df9df758e5e9d 100644
--- a/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc
+++ b/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc
@@ -271,16 +271,7 @@ bool GetChromeExePath(FilePath* chrome_path) {
// Chrome doesn't appear to be installed per user.
// Now check %programfiles(x86)%\google\chrome\application
- // TODO(abodenha@chromium.org) Extend PathService::Get to be able to
- // return the X86 program files path. At a minimum, use SHGetKnownFolderPath
- // instead.
- wchar_t system_buffer[MAX_PATH] = L"";
- SHGetFolderPath(NULL,
- CSIDL_PROGRAM_FILESX86,
- NULL,
- SHGFP_TYPE_CURRENT,
- system_buffer);
- path = FilePath(system_buffer);
+ PathService::Get(base::DIR_PROGRAM_FILESX86, &path);
path = path.Append(kChromeExePath);
if (file_util::PathExists(path)) {
*chrome_path = FilePath(path.value());
« no previous file with comments | « base/base_paths_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698