Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 6873069: Change the method name from enumerateDirectory to enumerateChosenDirectory in order to match the ... (Closed)

Created:
9 years, 8 months ago by John Gregg
Modified:
9 years ago
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Change the method name from enumerateDirectory to enumerateChosenDirectory in order to match the change in bugs.webkit.org/show_bug.cgi?id=58401 BUG=58977 TEST=drag a folder onto a webkitdirectory control Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82130

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M content/renderer/render_view.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Gregg
9 years, 8 months ago (2011-04-19 08:04:18 UTC) #1
darin (slow to review)
http://codereview.chromium.org/6873069/diff/1/content/renderer/render_view.h File content/renderer/render_view.h (right): http://codereview.chromium.org/6873069/diff/1/content/renderer/render_view.h#newcode375 content/renderer/render_view.h:375: virtual bool enumerateChosenDirectory( nit: please make sure the functions ...
9 years, 8 months ago (2011-04-19 17:21:48 UTC) #2
darin (slow to review)
LGTM w/ that change. On Tue, Apr 19, 2011 at 10:21 AM, <darin@chromium.org> wrote: > ...
9 years, 8 months ago (2011-04-19 17:34:10 UTC) #3
John Gregg
9 years, 8 months ago (2011-04-19 18:11:07 UTC) #4
On 2011/04/19 17:21:48, darin wrote:
> http://codereview.chromium.org/6873069/diff/1/content/renderer/render_view.h
> File content/renderer/render_view.h (right):
> 
>
http://codereview.chromium.org/6873069/diff/1/content/renderer/render_view.h#...
> content/renderer/render_view.h:375: virtual bool enumerateChosenDirectory(
> nit: please make sure the functions are listed in the same order that they
> appear in WebViewClient.

Done

Powered by Google App Engine
This is Rietveld 408576698