Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: content/renderer/render_view.h

Issue 6873069: Change the method name from enumerateDirectory to enumerateChosenDirectory in order to match the ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/renderer/render_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <map> 10 #include <map>
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 virtual void didChangeLoadProgress(WebKit::WebFrame* frame, 365 virtual void didChangeLoadProgress(WebKit::WebFrame* frame,
366 double load_progress); 366 double load_progress);
367 virtual bool isSmartInsertDeleteEnabled(); 367 virtual bool isSmartInsertDeleteEnabled();
368 virtual bool isSelectTrailingWhitespaceEnabled(); 368 virtual bool isSelectTrailingWhitespaceEnabled();
369 virtual void didChangeSelection(bool is_selection_empty); 369 virtual void didChangeSelection(bool is_selection_empty);
370 virtual void didExecuteCommand(const WebKit::WebString& command_name); 370 virtual void didExecuteCommand(const WebKit::WebString& command_name);
371 virtual bool handleCurrentKeyboardEvent(); 371 virtual bool handleCurrentKeyboardEvent();
372 virtual bool runFileChooser( 372 virtual bool runFileChooser(
373 const WebKit::WebFileChooserParams& params, 373 const WebKit::WebFileChooserParams& params,
374 WebKit::WebFileChooserCompletion* chooser_completion); 374 WebKit::WebFileChooserCompletion* chooser_completion);
375 virtual bool enumerateDirectory( 375 virtual bool enumerateChosenDirectory(
darin (slow to review) 2011/04/19 17:21:48 nit: please make sure the functions are listed in
376 const WebKit::WebString& path, 376 const WebKit::WebString& path,
377 WebKit::WebFileChooserCompletion* chooser_completion); 377 WebKit::WebFileChooserCompletion* chooser_completion);
378 virtual void runModalAlertDialog(WebKit::WebFrame* frame, 378 virtual void runModalAlertDialog(WebKit::WebFrame* frame,
379 const WebKit::WebString& message); 379 const WebKit::WebString& message);
380 virtual bool runModalConfirmDialog(WebKit::WebFrame* frame, 380 virtual bool runModalConfirmDialog(WebKit::WebFrame* frame,
381 const WebKit::WebString& message); 381 const WebKit::WebString& message);
382 virtual bool runModalPromptDialog(WebKit::WebFrame* frame, 382 virtual bool runModalPromptDialog(WebKit::WebFrame* frame,
383 const WebKit::WebString& message, 383 const WebKit::WebString& message,
384 const WebKit::WebString& default_value, 384 const WebKit::WebString& default_value,
385 WebKit::WebString* actual_value); 385 WebKit::WebString* actual_value);
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
1162 // bunch of stuff, you should probably create a helper class and put your 1162 // bunch of stuff, you should probably create a helper class and put your
1163 // data and methods on that to avoid bloating RenderView more. You can use 1163 // data and methods on that to avoid bloating RenderView more. You can use
1164 // the Observer interface to filter IPC messages and receive frame change 1164 // the Observer interface to filter IPC messages and receive frame change
1165 // notifications. 1165 // notifications.
1166 // --------------------------------------------------------------------------- 1166 // ---------------------------------------------------------------------------
1167 1167
1168 DISALLOW_COPY_AND_ASSIGN(RenderView); 1168 DISALLOW_COPY_AND_ASSIGN(RenderView);
1169 }; 1169 };
1170 1170
1171 #endif // CONTENT_RENDERER_RENDER_VIEW_H_ 1171 #endif // CONTENT_RENDERER_RENDER_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698