Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 6873006: X64 tweaks. (Closed)

Created:
9 years, 8 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

X64 tweaks. Use movapd instead of movsd to move between xmm registers. Avoids partial register writes and potential stalls. Use xorps instead of xorpd to zero a register. Same effect and latency, but one byte smaller. Committed: http://code.google.com/p/v8/source/detail?r=7631

Patch Set 1 #

Patch Set 2 : Added movaps and used it instead of movapd. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -32 lines) Patch
M src/x64/assembler-x64.h View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 3 chunks +63 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 5 chunks +40 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 11 chunks +13 lines, -13 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 8 months ago (2011-04-15 12:20:46 UTC) #1
William Hesse
9 years, 8 months ago (2011-04-15 12:54:54 UTC) #2
LGTM, but you should change movapd to movaps, according to the optimization
manual.

Powered by Google App Engine
This is Rietveld 408576698