Cleanup of mjsunit.js code and make assertEquals more strict.

Cleanup of mjsunit.js code and make assertEquals more strict.

Encapsulate the helper functions in mjsunit.js.
Now only exposes the exception class and the assertXXX functions.

Make assertEquals use === instead of ==.
This prevents a lot of possiblefalse positives in tests, and avoids
having to do assertTrue(expected === actual) when you need it.

Fixed some tests that were either buggy or assuming == test.

Committed: http://code.google.com/p/v8/source/detail?r=7628

[Søren Thygesen Gjesse, 2011-04-15 10:20:51]

LGTM

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mirror-object.js
File test/mjsunit/mirror-object.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mirror-object.j...
test/mjsunit/mirror-object.js:143: }
Should we test that there actually is no value property?

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mirror-object.j...
test/mjsunit/mirror-object.js:158: }1
1 -> ;

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mjsunit.js#newc...
test/mjsunit/mjsunit.js:248: assertEquals(expected[i], found[i], start + "array
element at index " + i);
Long line.

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/number-tostring.js
File test/mjsunit/number-tostring.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/number-tostring...
test/mjsunit/number-tostring.js:222: assertEquals("-1", (-0.5).toFixed(0),
"-0.5.toFixed(0)");
() in the message string as well.

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regexp-static.js
File test/mjsunit/regexp-static.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regexp-static.j...
test/mjsunit/regexp-static.js:137: assertEquals(["foo",undefined],
/foo(?:a(x))?/.exec("foobx"),
void 0 instead of undefined?

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-176.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-176.js:30: assertArrayEquals(["f", undefined],
void 0 instead of undefined (times 3)?

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-187.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-187.js:30: assertEquals(["f", undefined],
"foo".match(/(?:(?=(f)o)fx|)./));
Ditto.

[Lasse Reichstein, 2011-04-15 11:33:54]

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mirror-object.js
File test/mjsunit/mirror-object.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mirror-object.j...
test/mjsunit/mirror-object.js:143: }
let's.
Also, it seems I need to handle that NaN and Infinity are strings.

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mirror-object.j...
test/mjsunit/mirror-object.js:158: }1
Removed the spurious "1".

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/mjsunit.js#newc...
test/mjsunit/mjsunit.js:248: assertEquals(expected[i], found[i], start + "array
element at index " + i);
Wrapped.

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regexp-static.js
File test/mjsunit/regexp-static.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regexp-static.j...
test/mjsunit/regexp-static.js:137: assertEquals(["foo",undefined],
/foo(?:a(x))?/.exec("foobx"),
Not necessary, and not more readable.

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-176.js (right):

http://codereview.chromium.org/6869007/diff/2001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-176.js:30: assertArrayEquals(["f", undefined],
Not necessaary.