test/mjsunit/cyrillic.js - Issue 6869007: Cleanup of mjsunit.js code and make assertEquals more strict.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/cyrillic.js

Issue 6869007: Cleanup of mjsunit.js code and make assertEquals more strict. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed review comments Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/cyrillic.js

diff --git a/test/mjsunit/cyrillic.js b/test/mjsunit/cyrillic.js

index c5712e6f9d1dbd563aa7fa285971061a53239552..9b21c4f8ecaf573e1f5c6a835b5ae301d004b45e 100644

--- a/test/mjsunit/cyrillic.js

+++ b/test/mjsunit/cyrillic.js

@@ -187,9 +187,9 @@ for (var add_non_ascii_character_to_subject = 0;

var ignore_case = (j == 0);

var flag = ignore_case ? "i" : "";

var re = new RegExp(mixed, flag);

- assertEquals(ignore_case || (full && add_non_ascii_character_to_subject),

- re.test("A" + suffix),

- 58 + flag + f);

+ var expected =

+ ignore_case || (full && !!add_non_ascii_character_to_subject);

+ assertEquals(expected, re.test("A" + suffix), 58 + flag + f);

assertTrue(re.test("a" + suffix), 59 + flag + f);

assertTrue(re.test("~" + suffix), 60 + flag + f);

assertTrue(re.test(cyrillic.MIDDLE), 61 + flag + f);

« no previous file with comments | « test/mjsunit/const.js ('k') | test/mjsunit/debug-scopes.js » ('j') | no next file with comments »