chrome/browser/extensions/extension_sync_data.h - Issue 6852029: [Sync] Move some extension-sync-related logic to ExtensionService

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_sync_data.h

Issue 6852029: [Sync] Move some extension-sync-related logic to ExtensionService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add TODO, fix lint Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sync_data.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_

	6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_

	7 #pragma once

	8

	9 #include <string>

	10

	11 #include "base/version.h"

	12 #include "googleurl/src/gurl.h"

	13

	14 struct ExtensionSyncData {
	asargent_no_longer_on_chrome 2011/04/14 23:32:14 nit: Even though this is just a struct, it would b nit: Even though this is just a struct, it would be helpful if you had a brief overview comment here ala http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Class_Comments akalin 2011/04/15 01:17:11 Done. Show quoted text On 2011/04/14 23:32:14, Antony Sargent wrote: > nit: Even though this is just a struct, it would be helpful if you had a brief > overview comment here ala > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Class_Comments Done.
	15 ExtensionSyncData();

	16 ~ExtensionSyncData();

	17

	18 std::string id;

	19

	20 // Version-independent properties.

	21 bool uninstalled;

	22 bool enabled;

	23 bool incognito_enabled;

	24

	25 Version version;

	26

	27 // Version-dependent properties.
	asargent_no_longer_on_chrome 2011/04/14 23:32:14 Isn't "version" version-dependent? :) Actually I' Isn't "version" version-dependent? :) Actually I'm a little confused by what you mean by version-dependent and version-independent. Do you mean that the update url could change between 2 versions of an extension, but it's not possible that sync would also notice a change in the enabled or incognito setting in the same sync "transaction"? akalin 2011/04/15 01:17:11 Added clarifying comments. Show quoted text On 2011/04/14 23:32:14, Antony Sargent wrote: > Isn't "version" version-dependent? :) > > Actually I'm a little confused by what you mean by version-dependent and > version-independent. Do you mean that the update url could change between 2 > versions of an extension, but it's not possible that sync would also notice a > change in the enabled or incognito setting in the same sync "transaction"? Added clarifying comments.
	28 GURL update_url;

	29 };

	30

	31 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SYNC_DATA_H_

OLD	NEW