[Sync] Move some extension-sync-related logic to ExtensionService

chrome/browser/extensions/extension_service.h

Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 9fd84e226957f3cea94f4fd42e4ad643eb18060a..4ac8b7f8fc879fa1603876a94c2c3bb45224a46f 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -39,6 +39,7 @@
 class ExtensionBrowserEventRouter;
 class ExtensionPreferenceEventRouter;
 class ExtensionServiceBackend;
+class ExtensionSyncData;
 class ExtensionToolbarModel;
 class ExtensionUpdater;
 class GURL;
@@ -81,9 +82,19 @@ class ExtensionServiceInterface {
 
   // Safe to call multiple times in a row.
   //
-  // TODO(akalin): Remove this method (and others) once we add
-  // ProcessSyncData().
+  // TODO(akalin): Remove this method (and others) once we refactor
+  // themes sync to not use it directly.
   virtual void CheckForUpdatesSoon() = 0;
+
+  // TODO(akalin): We'll eventually need a separate method for app
+  // sync.

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

Can you a bug for this and link to it here? The bug should have a quick
explanation of what's going to be different about app sync.

[akalin, 2011/04/15 01:17:11]

There are already a couple of bugs filed: added them.

+  virtual void ProcessSyncData(
+      const ExtensionSyncData& extension_sync_data) = 0;
+
+  // TODO(akalin): Add a method like:
+  // virtual void
+  //   GetInitialSyncData(bool (*filter)(Extension),

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

It's not immediately obvious to me what this would mean - could you expand the
comment a little to explain what the method would do?

[akalin, 2011/04/15 01:17:11]

Done.

+  //                      map<string, ExtensionSyncData>* out) const;
 };
 
 // Manages installed and running Chromium extensions.
@@ -345,6 +356,9 @@ class ExtensionService
 
   virtual void CheckForUpdatesSoon();
 
+  virtual void ProcessSyncData(
+      const ExtensionSyncData& extension_sync_data);

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

Please include a comment describing what the method does. (Eventually we should
probably clean this up too to move such comments up to the interface for all
methods in the interface).

[akalin, 2011/04/15 01:17:11]

Done, but added it to the interface method (might as well start now).

+
   void set_extensions_enabled(bool enabled) { extensions_enabled_ = enabled; }
   bool extensions_enabled() { return extensions_enabled_; }