[Sync] Move some extension-sync-related logic to ExtensionService

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 21 matching lines @@
 #include "chrome/browser/prefs/pref_change_registrar.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/browser/browser_thread.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 #include "content/common/property_bag.h"
 
 class ExtensionBrowserEventRouter;
 class ExtensionPreferenceEventRouter;
 class ExtensionServiceBackend;
+class ExtensionSyncData;
 class ExtensionToolbarModel;
 class ExtensionUpdater;
 class GURL;
 class PendingExtensionManager;
 class Profile;
 class Version;
 
 // This is an interface class to encapsulate the dependencies that
 // various classes have on ExtensionService. This allows easy mocking.
 class ExtensionServiceInterface {
@@ skipping 22 matching lines @@
     const std::vector<std::string>& blacklist) = 0;
   virtual void CheckAdminBlacklist() = 0;
   virtual bool HasInstalledExtensions() = 0;
 
   virtual bool IsIncognitoEnabled(const std::string& extension_id) const = 0;
   virtual void SetIsIncognitoEnabled(const std::string& extension_id,
                                      bool enabled) = 0;
 
   // Safe to call multiple times in a row.
   //
-  // TODO(akalin): Remove this method (and others) once we add
-  // ProcessSyncData().
+  // TODO(akalin): Remove this method (and others) once we refactor
+  // themes sync to not use it directly.
   virtual void CheckForUpdatesSoon() = 0;
+
+  // TODO(akalin): We'll eventually need a separate method for app
+  // sync.

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

Can you a bug for this and link to it here? The bug should have a quick
explanation of what's going to be different about app sync.

[akalin, 2011/04/15 01:17:11]

There are already a couple of bugs filed: added them.

+  virtual void ProcessSyncData(
+      const ExtensionSyncData& extension_sync_data) = 0;
+
+  // TODO(akalin): Add a method like:
+  // virtual void
+  //   GetInitialSyncData(bool (*filter)(Extension),

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

It's not immediately obvious to me what this would mean - could you expand the
comment a little to explain what the method would do?

[akalin, 2011/04/15 01:17:11]

Done.

+  //                      map<string, ExtensionSyncData>* out) const;
 };
 
 // Manages installed and running Chromium extensions.
 class ExtensionService
     : public base::RefCountedThreadSafe<ExtensionService,
                                         BrowserThread::DeleteOnUIThread>,
       public ExtensionServiceInterface,
       public ExternalExtensionProviderInterface::VisitorInterface,
       public NotificationObserver {
  public:
@@ skipping 241 matching lines @@
   virtual void UpdateExtensionBlacklist(
     const std::vector<std::string>& blacklist);
 
   // Go through each extension and unload those that the network admin has
   // put on the blacklist (not to be confused with the Google managed blacklist
   // set of extensions.
   virtual void CheckAdminBlacklist();
 
   virtual void CheckForUpdatesSoon();
 
+  virtual void ProcessSyncData(
+      const ExtensionSyncData& extension_sync_data);

[asargent_no_longer_on_chrome, 2011/04/14 23:32:14]

Please include a comment describing what the method does. (Eventually we should
probably clean this up too to move such comments up to the interface for all
methods in the interface).

[akalin, 2011/04/15 01:17:11]

Done, but added it to the interface method (might as well start now).

+
   void set_extensions_enabled(bool enabled) { extensions_enabled_ = enabled; }
   bool extensions_enabled() { return extensions_enabled_; }
 
   void set_show_extensions_prompts(bool enabled) {
     show_extensions_prompts_ = enabled;
   }
 
   bool show_extensions_prompts() {
     return show_extensions_prompts_;
   }
@@ skipping 223 matching lines @@
   bool external_extension_url_added_;
 
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsWithUnlimtedStorage);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsAndCheckStorageProtection);
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_