Issue 6825008: First stab at using Rietveld wrapper object in both gcl.py and git-cl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6825008: First stab at using Rietveld wrapper object in both gcl.py and git-cl. (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

First stab at using Rietveld wrapper object in both gcl.py and git-cl. Exposes InputApi.rietveld and deprecate host_url. This is useful since it places authentication at a single place. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81019

Patch Set 1 #

Total comments: 1

Patch Set 2 : small fix #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -81 lines)			Patch
M	gcl.py	View	1	8 chunks	+26 lines, -27 lines	0 comments	Download
M	git_cl.py	View		6 chunks	+11 lines, -9 lines	0 comments	Download
M	presubmit_support.py	View		10 chunks	+20 lines, -20 lines	0 comments	Download
M	rietveld.py	View		3 chunks	+12 lines, -7 lines	0 comments	Download
M	tests/gcl_unittest.py	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/presubmit_unittest.py	View		9 chunks	+13 lines, -11 lines	0 comments	Download
M	third_party/upload.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/6825008/diff/1/third_party/upload.py File third_party/upload.py (left): http://codereview.chromium.org/6825008/diff/1/third_party/upload.py#oldcode2071 third_party/upload.py:2071: logging.basicConfig(format=("%(asctime).19s %(levelname)s %(filename)s:" I'll upstream this change to move ...

9 years, 8 months ago (2011-04-08 18:48:23 UTC) #1

LGTM. Nice.

Expand Messages | Collapse Messages