tests/gcl_unittest.py - Issue 6825008: First stab at using Rietveld wrapper object in both gcl.py and git-cl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gcl_unittest.py

Issue 6825008: First stab at using Rietveld wrapper object in both gcl.py and git-cl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: small fix Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gcl_unittest.py

diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py

index e634aef938226804671ba5e8de6cab86bc87c32b..c93ff767775045b8b80c93197a7230470e34cfc8 100755

--- a/tests/gcl_unittest.py

+++ b/tests/gcl_unittest.py

@@ -91,9 +91,9 @@ class GclUnittest(GclTestsBase):

'RunShell', 'RunShellWithReturnCode', 'SVN',

'TryChange', 'UnknownFiles', 'Warn',

'attrs', 'breakpad', 'defer_attributes', 'fix_encoding',

- 'gclient_utils', 'getpass',

- 'json', 'main', 'need_change', 'need_change_and_args', 'no_args',

- 'optparse', 'os', 'presubmit_support', 'random', 're',

+ 'gclient_utils', 'json', 'main', 'need_change', 'need_change_and_args',

+ 'no_args', 'optparse', 'os', 'presubmit_support', 'random', 're',

+ 'rietveld',

'string', 'subprocess', 'subprocess2', 'sys', 'tempfile', 'time',

'upload', 'urllib2',

]

@@ -179,7 +179,7 @@ class ChangeInfoUnittest(GclTestsBase):

members = [

'CloseIssue', 'Delete', 'Exists', 'GetFiles', 'GetFileNames',

'GetLocalRoot', 'GetIssueDescription', 'Load', 'MissingTests',

- 'NeedsUpload', 'PrimeLint', 'Save', 'SendToRietveld',

+ 'NeedsUpload', 'PrimeLint', 'RpcServer', 'Save', 'SendToRietveld',

'UpdateRietveldDescription',

'description', 'issue', 'name',

'needs_upload', 'patch', 'patchset', 'reviewers', 'rietveld',

« no previous file with comments | « rietveld.py ('k') | tests/presubmit_unittest.py » ('j') | no next file with comments »