Issue 6822063: Revert 81278 - Profile shouldn't own PinnedTabService.PinnedTabService is now owned by PinnedTabS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6822063: Revert 81278 - Profile shouldn't own PinnedTabService.PinnedTabService is now owned by PinnedTabS... (Closed)

Created:
9 years, 8 months ago by Sigurður Ásgeirsson

Modified:
9 years, 7 months ago

Reviewers:
Torne

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 81278 - Profile shouldn't own PinnedTabService.PinnedTabService is now owned by PinnedTabServiceFactory, using Profileas a key. This uses the ProfileKeyedService infrastructure originallycreated for ThemeServiceFactory.BUG=77155 TEST=existing testsReview URL: http://codereview.chromium.org/6820065 TBR=torne@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81284

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -74 lines)			Patch
M	chrome/browser/profiles/profile.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/pinned_tab_service.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
D	chrome/browser/tabs/pinned_tab_service_factory.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	chrome/browser/tabs/pinned_tab_service_factory.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)