Issue 6820065: Profile shouldn't own PinnedTabService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6820065: Profile shouldn't own PinnedTabService. (Closed)

Created:
9 years, 8 months ago by Torne

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan, commit-bot: I haz the power, Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Profile shouldn't own PinnedTabService. PinnedTabService is now owned by PinnedTabServiceFactory, using Profile as a key. This uses the ProfileKeyedService infrastructure originally created for ThemeServiceFactory. BUG=77155 TEST=existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81390

Patch Set 1 #

Patch Set 2 : Cosmetic tweak #

Patch Set 3 : Rebase, fix compile error #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -5 lines)			Patch
M	chrome/browser/profiles/profile.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/pinned_tab_service.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
A	chrome/browser/tabs/pinned_tab_service_factory.h	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
A	chrome/browser/tabs/pinned_tab_service_factory.cc	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Torne

PinnedTabService is entirely trivial since it functions solely by observation :)

9 years, 8 months ago (2011-04-12 10:51:52 UTC) #1

Elliot Glaysher

On 2011/04/12 10:51:52, Torne wrote: > PinnedTabService is entirely trivial since it functions solely by ...

9 years, 8 months ago (2011-04-12 17:37:04 UTC) #2

Change committed as 81390

Expand Messages | Collapse Messages