Fix erratic HTML5 audio playback

media/audio/audio_output_dispatcher.h

Index: media/audio/audio_output_dispatcher.h
diff --git a/media/audio/audio_output_dispatcher.h b/media/audio/audio_output_dispatcher.h
index 2289e8909de45a80f6a30017fc2bd4620ddb14bc..bdf96c2fc77ee3c3bc01481d87735bc86bacd96c 100644
--- a/media/audio/audio_output_dispatcher.h
+++ b/media/audio/audio_output_dispatcher.h
@@ -22,6 +22,7 @@
 #define MEDIA_AUDIO_AUDIO_OUTPUT_DISPATCHER_H_
 
 #include <vector>
+#include <list>

[scherkus (not reviewing), 2011/04/11 22:32:33]

nit: list comes before vector

 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
@@ -76,6 +77,10 @@ class AudioOutputDispatcher
   // it in |streams_|.
   void OpenTask();
 
+  // Before a stream is reused, it should sit idle for a bit.  This task is
+  // called once that time has elapsed.
+  void StopStreamTask();
+
   // Called by |close_timer_|. Closes all pending stream.
   void ClosePendingStreams();
 
@@ -85,6 +90,7 @@ class AudioOutputDispatcher
 
   size_t paused_proxies_;
   std::vector<AudioOutputStream*> streams_;
+  std::list<AudioOutputStream*> idle_streams_;

[Sergey Ulanov, 2011/04/09 07:02:05]

Please add comments that explain difference between streams_ and idle_streams_.
I'm not sure if idle_streams_ is a good name. Maybe call it pausing_streams_,
and rename streams_ to idle_streams_, to show the difference? In that case we
would not need a comment.

   base::DelayTimer<AudioOutputDispatcher> close_timer_;
 
   DISALLOW_COPY_AND_ASSIGN(AudioOutputDispatcher);