[login_manager] Fix race condition that caused ownership to never work

[login_manager] Fix race condition that caused ownership to never work

There's a race to create the user's NSSDB between chrome and the
session manager.  If the session manager wins, that directory and the
files within are owned by root, which is bad.

BUG=14008
TEST=unit, and suite_Smoke (incl login_OwnershipTaken)

Change-Id: I58080f281408c1f8e3d6692f5759148667a7bdff

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3667b02

[Chris Masone, 2011-04-09 06:52:05]

PTAL

[gauravsh, 2011-04-09 18:19:05]

How does the addition of MightHaveOwnerKey check fix the race condition - I
don't quite get it based on the issue description, but maybe it's obvious.

[Chris Masone, 2011-04-09 18:29:25]

because, if !MightHaveKeys(), then the session manager doesn't try to
OpenUserDB().  The underlying nss wrapper code will try to create the DB if
it's not there already, which is the problem.  So, we explicitly make sure
it's there before we try to open it.

On Sat, Apr 9, 2011 at 11:19 AM, <gauravsh@chromium.org> wrote:

> How does the addition of MightHaveOwnerKey check fix the race condition - I
> don't quite get it based on the issue description, but maybe it's obvious.
>
>
> http://codereview.chromium.org/6820024/
>

[gauravsh, 2011-04-09 18:35:02]

LGTM