extensions: Internationalize error code messages.

extensions: Internationalize error code messages.

BUG=23086
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41380

[tfarina (gmail-do not use), 2010-03-09 00:49:06]

Hi Aaron, could you review this to me?

[Aaron Boodman, 2010-03-09 02:51:11]

Thank you for doing this. If you are interested, I believe there are some
similar issues in Extension::InitFromValue()
(chrome/common/extensions/extension.cc) and in ValidateExtension in
chrome/browser/extensions/extension_file_util.cc.

http://codereview.chromium.org/682001/diff/2001/3001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/682001/diff/2001/3001#newcode3244
chrome/app/generated_resources.grd:3244: <message
name="IDS_EXTENSION_DIRECTORY_NO_EXISTS" desc="Warning displayed in popup dialog
when the extension directory no exists.">
English grammar error in description. Should be:

Warning displayed in popup dialog when the extension directory does not exist.

http://codereview.chromium.org/682001/diff/2001/3001#newcode3244
chrome/app/generated_resources.grd:3244: <message
name="IDS_EXTENSION_DIRECTORY_NO_EXISTS" desc="Warning displayed in popup dialog
when the extension directory no exists.">
For each of these errors, you can replace "in popup dialog" with "in pack
dialog".

http://codereview.chromium.org/682001/diff/2001/3001#newcode3252
chrome/app/generated_resources.grd:3252: Reuse that key or delete it first.
Move this onto the previous line.

http://codereview.chromium.org/682001/diff/2001/3001#newcode3254
chrome/app/generated_resources.grd:3254: <message
name="IDS_EXTENSION_PRIVATE_KEY_NO_EXISTS" desc="Warning displayed in popup
dialog when the private key for the extension no exists.">
no exists -> does not exist

[tfarina (gmail-do not use), 2010-03-10 00:26:35]

On 2010/03/09 02:51:11, Aaron Boodman wrote:
> Thank you for doing this. If you are interested, I believe there are some
> similar issues in Extension::InitFromValue()
> (chrome/common/extensions/extension.cc) and in ValidateExtension in
> chrome/browser/extensions/extension_file_util.cc.
> 

Sure, I would like to do them. If you don't mind, I also would like to do them
as a separated CL.

http://codereview.chromium.org/682001/diff/2001/3001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/682001/diff/2001/3001#newcode3244
chrome/app/generated_resources.grd:3244: <message
name="IDS_EXTENSION_DIRECTORY_NO_EXISTS" desc="Warning displayed in popup dialog
when the extension directory no exists.">
On 2010/03/09 02:51:12, Aaron Boodman wrote:
> English grammar error in description. Should be:
> 
> Warning displayed in popup dialog when the extension directory does not exist.

Done.

http://codereview.chromium.org/682001/diff/2001/3001#newcode3244
chrome/app/generated_resources.grd:3244: <message
name="IDS_EXTENSION_DIRECTORY_NO_EXISTS" desc="Warning displayed in popup dialog
when the extension directory no exists.">
On 2010/03/09 02:51:12, Aaron Boodman wrote:
> For each of these errors, you can replace "in popup dialog" with "in pack
> dialog".

Done.

http://codereview.chromium.org/682001/diff/2001/3001#newcode3252
chrome/app/generated_resources.grd:3252: Reuse that key or delete it first.
On 2010/03/09 02:51:12, Aaron Boodman wrote:
> Move this onto the previous line.

Done.

http://codereview.chromium.org/682001/diff/2001/3001#newcode3254
chrome/app/generated_resources.grd:3254: <message
name="IDS_EXTENSION_PRIVATE_KEY_NO_EXISTS" desc="Warning displayed in popup
dialog when the private key for the extension no exists.">
On 2010/03/09 02:51:12, Aaron Boodman wrote:
> no exists -> does not exist

Done.

[Aaron Boodman, 2010-03-10 21:42:01]

lgtm

[tfarina (gmail-do not use), 2010-03-12 02:43:01]

On 2010/03/10 21:42:01, Aaron Boodman wrote:
> lgtm

Thanks Aaron.