Issue 6816056: Fix the behaviour of "JavaScript Console" menu item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6816056: Fix the behaviour of "JavaScript Console" menu item. (Closed)

Created:
9 years, 8 months ago by keishi-hattori

Modified:
7 years, 8 months ago

Reviewers:
pfeldman

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Fix the behaviour of "JavaScript Console" menu item so it toggles the JavaScript console and keeps the Inspector open. Requires patch for WebKit (https://bugs.webkit.org/show_bug.cgi?id=57531) Bug=70846 TEST=Press Ctrl+Shift+I, Ctrl+Shift+J, Ctrl+Shift+J and confirm that the Inspector is open and the Console is not.

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -12 lines)			Patch
M	chrome/browser/debugger/devtools_manager.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/debugger/devtools_manager.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

I don't think this change fixes the following use case: - Inspector is opened and ...

9 years, 8 months ago (2011-04-08 13:55:20 UTC) #1

keishi-hattori

On 2011/04/08 13:55:20, pfeldman wrote: > Expected: > Focus is brought to the developer tools ...

9 years, 8 months ago (2011-04-11 09:36:54 UTC) #2

pfeldman

9 years, 8 months ago (2011-04-11 11:46:44 UTC) #3

> Really? I thought the correct behavior of "Developer Tools" menu was to toggle
> the developer tools. I suspect many users find toggling with shortcut keys
> useful.

That's why it is still not fixed. Shortcut should definitely toggle devtools,
but menu item is supposed to bring it up according to its title. The tricky
thing is that they shared the shortcut (i.e. it is essentially the same action).

Expand Messages | Collapse Messages