Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: chrome/browser/debugger/devtools_manager.h

Issue 6816056: Fix the behaviour of "JavaScript Console" menu item. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void ForwardToDevToolsClient(RenderViewHost* inspected_rvh, 60 void ForwardToDevToolsClient(RenderViewHost* inspected_rvh,
61 const IPC::Message& message); 61 const IPC::Message& message);
62 62
63 void ActivateWindow(RenderViewHost* client_rvn); 63 void ActivateWindow(RenderViewHost* client_rvn);
64 void CloseWindow(RenderViewHost* client_rvn); 64 void CloseWindow(RenderViewHost* client_rvn);
65 void RequestDockWindow(RenderViewHost* client_rvn); 65 void RequestDockWindow(RenderViewHost* client_rvn);
66 void RequestUndockWindow(RenderViewHost* client_rvn); 66 void RequestUndockWindow(RenderViewHost* client_rvn);
67 67
68 void OpenDevToolsWindow(RenderViewHost* inspected_rvh); 68 void OpenDevToolsWindow(RenderViewHost* inspected_rvh);
69 void ToggleDevToolsWindow(RenderViewHost* inspected_rvh, 69 void ToggleDevToolsWindow(RenderViewHost* inspected_rvh,
70 bool force_open,
70 DevToolsToggleAction action); 71 DevToolsToggleAction action);
71 void RuntimePropertyChanged(RenderViewHost* inspected_rvh, 72 void RuntimePropertyChanged(RenderViewHost* inspected_rvh,
72 const std::string& name, 73 const std::string& name,
73 const std::string& value); 74 const std::string& value);
74 75
75 // Starts element inspection in the devtools client. 76 // Starts element inspection in the devtools client.
76 // Creates one by means of OpenDevToolsWindow if no client 77 // Creates one by means of OpenDevToolsWindow if no client
77 // exists. 78 // exists.
78 void InspectElement(RenderViewHost* inspected_rvh, int x, int y); 79 void InspectElement(RenderViewHost* inspected_rvh, int x, int y);
79 80
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // client hosted by DevToolsClientHost. 119 // client hosted by DevToolsClientHost.
119 RenderViewHost* GetInspectedRenderViewHost(DevToolsClientHost* client_host); 120 RenderViewHost* GetInspectedRenderViewHost(DevToolsClientHost* client_host);
120 121
121 void SendAttachToAgent(RenderViewHost* inspected_rvh); 122 void SendAttachToAgent(RenderViewHost* inspected_rvh);
122 void SendDetachToAgent(RenderViewHost* inspected_rvh); 123 void SendDetachToAgent(RenderViewHost* inspected_rvh);
123 124
124 void ForceReopenWindow(); 125 void ForceReopenWindow();
125 126
126 DevToolsClientHost* FindOwnerDevToolsClientHost(RenderViewHost* client_rvh); 127 DevToolsClientHost* FindOwnerDevToolsClientHost(RenderViewHost* client_rvh);
127 128
128 void ToggleDevToolsWindow(RenderViewHost* inspected_rvh,
129 bool force_open,
130 DevToolsToggleAction action);
131
132 void ReopenWindow(RenderViewHost* client_rvh, bool docked); 129 void ReopenWindow(RenderViewHost* client_rvh, bool docked);
133 130
134 void BindClientHost(RenderViewHost* inspected_rvh, 131 void BindClientHost(RenderViewHost* inspected_rvh,
135 DevToolsClientHost* client_host, 132 DevToolsClientHost* client_host,
136 const DevToolsRuntimeProperties& runtime_properties); 133 const DevToolsRuntimeProperties& runtime_properties);
137 134
138 void UnbindClientHost(RenderViewHost* inspected_rvh, 135 void UnbindClientHost(RenderViewHost* inspected_rvh,
139 DevToolsClientHost* client_host); 136 DevToolsClientHost* client_host);
140 137
141 // These two maps are for tracking dependencies between inspected tabs and 138 // These two maps are for tracking dependencies between inspected tabs and
(...skipping 22 matching lines...) Expand all
164 OrphanClientHosts; 161 OrphanClientHosts;
165 OrphanClientHosts orphan_client_hosts_; 162 OrphanClientHosts orphan_client_hosts_;
166 int last_orphan_cookie_; 163 int last_orphan_cookie_;
167 164
168 NotificationRegistrar registrar_; 165 NotificationRegistrar registrar_;
169 166
170 DISALLOW_COPY_AND_ASSIGN(DevToolsManager); 167 DISALLOW_COPY_AND_ASSIGN(DevToolsManager);
171 }; 168 };
172 169
173 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_ 170 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698