Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 6816027: Make the windows_version.h functions threadsafe by using a singleton. Add accessors to the singl... (Closed)

Created:
9 years, 8 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), darin-cc_chromium.org, native-client-reviews_googlegroups.com, scherkus (not reviewing)
Visibility:
Public.

Description

Make the windows_version.h functions threadsafe by using a singleton. Add accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll). A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -334 lines) Patch
M base/file_version_info_win.cc View 2 chunks +1 line, -4 lines 0 comments Download
M base/process_util_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M base/sys_info.h View 2 chunks +6 lines, -6 lines 0 comments Download
M base/sys_info_chromeos.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M base/sys_info_mac.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/sys_info_win.cc View 3 chunks +20 lines, -21 lines 0 comments Download
M base/win/windows_version.h View 1 chunk +76 lines, -39 lines 0 comments Download
M base/win/windows_version.cc View 2 chunks +36 lines, -64 lines 0 comments Download
M chrome/browser/bug_report_util.cc View 3 chunks +16 lines, -21 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 chunk +7 lines, -14 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 6 chunks +30 lines, -28 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/installer/util/install_util.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/out_of_proc_test_runner.cc View 1 chunk +12 lines, -0 lines 0 comments Download
MM media/tools/mfplayer/mf_playback_main.cc View 2 chunks +3 lines, -1 line 0 comments Download
MM media/tools/mfplayer/mfplayer.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/src/Wow64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/src/dep_test.cc View 3 chunks +2 lines, -28 lines 0 comments Download
M sandbox/src/integrity_level_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M sandbox/src/interception.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/src/job.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M sandbox/src/sandbox_utils.cc View 3 chunks +6 lines, -28 lines 0 comments Download
M sandbox/src/service_resolver_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/tests/common/controller.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M sandbox/tests/integration_tests/integration_tests.cc View 1 chunk +5 lines, -1 line 0 comments Download
M sandbox/tests/unit_tests/unit_tests.cc View 1 chunk +5 lines, -1 line 0 comments Download
M sandbox/tests/validation_tests/unit_tests.cc View 1 chunk +5 lines, -1 line 0 comments Download
M webkit/glue/user_agent.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_proxy_test.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
Carlos, can you review this second take patch? The only things you need to look ...
9 years, 8 months ago (2011-04-07 21:00:04 UTC) #1
cpu_(ooo_6.6-7.5)
9 years, 8 months ago (2011-04-07 22:11:43 UTC) #2
lgtm on the 4 files.

Powered by Google App Engine
This is Rietveld 408576698