Make the windows_version.h functions threadsafe by using a singleton. Add accessors to the singl...

chrome/browser/bug_report_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bug_report_util.h"
 
 #include <sstream>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/file_version_info.h"
 #include "base/memory/singleton.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
+#include "base/win/windows_version.h"
 #include "chrome/browser/browser_process_impl.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/safe_browsing_util.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/net/url_fetcher.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "googleurl/src/gurl.h"
 #include "grit/generated_resources.h"
@@ skipping 102 matching lines @@
     if (previous_delay_) {
       if (previous_delay_ < kRetryDelayLimit)
         previous_delay_ *= kRetryDelayIncreaseFactor;
     } else {
       previous_delay_ = kInitialRetryDelay;
     }
     BugReportUtil::DispatchFeedback(profile_, post_body_, previous_delay_);
 
     // Process the error for debug output
     if (response_code == kHttpPostFailNoConnection) {
-        error_stream << "No connection to server.";
+      error_stream << "No connection to server.";
     } else if ((response_code > kHttpPostFailClientError) &&
-      (response_code < kHttpPostFailServerError)) {
-        error_stream << "Client error: HTTP response code " << response_code;
+        (response_code < kHttpPostFailServerError)) {
+      error_stream << "Client error: HTTP response code " << response_code;
     } else if (response_code > kHttpPostFailServerError) {
-        error_stream << "Server error: HTTP response code " << response_code;
+      error_stream << "Server error: HTTP response code " << response_code;
     } else {
-        error_stream << "Unknown error: HTTP response code " << response_code;
+      error_stream << "Unknown error: HTTP response code " << response_code;
     }
   }
 
-  LOG(WARNING) << "FEEDBACK: Submission to feedback server (" << url <<
-      ") status: " << error_stream.str() << std::endl;
+  LOG(WARNING) << "FEEDBACK: Submission to feedback server (" << url
+               << ") status: " << error_stream.str();
 
   // Delete the URLFetcher.
   delete source;
   // And then delete ourselves.
   delete this;
 }
 
 // static
-void BugReportUtil::SetOSVersion(std::string *os_version) {
+void BugReportUtil::SetOSVersion(std::string* os_version) {
 #if defined(OS_WIN)
-  OSVERSIONINFO osvi;
-  ZeroMemory(&osvi, sizeof(OSVERSIONINFO));
-  osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
-
-  if (GetVersionEx(&osvi)) {
-    *os_version = StringPrintf("%d.%d.%d %S",
-      osvi.dwMajorVersion,
-      osvi.dwMinorVersion,
-      osvi.dwBuildNumber,
-      osvi.szCSDVersion);
-  } else {
-    *os_version = "unknown";
-  }
+  base::win::OSInfo* os_info = base::win::OSInfo::GetInstance();
+  base::win::OSInfo::VersionNumber version_number = os_info->version_number();
+  *os_version = StringPrintf("%d.%d.%d", version_number.major,
+                             version_number.minor, version_number.build);
+  int service_pack = os_info->service_pack().major;
+  if (service_pack > 0)
+    os_version->append(StringPrintf("Service Pack %d", service_pack));
 #elif defined(OS_MACOSX)
   int32 major;
   int32 minor;
   int32 bugFix;
   base::SysInfo::OperatingSystemVersionNumbers(&major, &minor, &bugFix);
   *os_version = StringPrintf("%d.%d.%d", major, minor, bugFix);
 #else
   *os_version = "unknown";
 #endif
 }
@@ skipping 200 matching lines @@
 
 // static
 void BugReportUtil::ReportPhishing(TabContents* currentTab,
                                    const std::string& phishing_url) {
   currentTab->controller().LoadURL(
       safe_browsing_util::GeneratePhishingReportUrl(
           kReportPhishingUrl, phishing_url),
       GURL(),
       PageTransition::LINK);
 }