Issue 6806009: Set returncode to subprocess2.TIMED_OUT instead of -9 when a process times out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6806009: Set returncode to subprocess2.TIMED_OUT instead of -9 when a process times out. (Closed)

Created:
9 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Set returncode to subprocess2.TIMED_OUT instead of -9 when a process times out. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80775

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rephrased docstring #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -36 lines)			Patch
	M	subprocess2.py	View	1	6 chunks	+61 lines, -35 lines	0 comments	Download
	M	tests/subprocess2_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

9 years, 8 months ago (2011-04-07 02:03:46 UTC) #3

LGTM with nits ...

http://codereview.chromium.org/6806009/diff/1/subprocess2.py
File subprocess2.py (right):

http://codereview.chromium.org/6806009/diff/1/subprocess2.py#newcode26
subprocess2.py:26: TIMED_OUT = -2001
Where did -2001 come from?

http://codereview.chromium.org/6806009/diff/1/subprocess2.py#newcode200
subprocess2.py:200: - The process will be kill with error code TIMED_OUT after
|timeout| seconds
You're not actually killing with an error code; I would rephrase this as:

"- The process will be killed after |timeout| seconds and returncode set to
TIMED_OUT"

Expand Messages | Collapse Messages