Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: tests/subprocess2_test.py

Issue 6806009: Set returncode to subprocess2.TIMED_OUT instead of -9 when a process times out. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Rephrased docstring Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « subprocess2.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/subprocess2_test.py
diff --git a/tests/subprocess2_test.py b/tests/subprocess2_test.py
index dfc91f6078e225c348b032a4f7ef5a2f42eb62ca..448a82d343a4a8957037d8bea6834c744e311927 100755
--- a/tests/subprocess2_test.py
+++ b/tests/subprocess2_test.py
@@ -136,7 +136,7 @@ class Subprocess2Test(unittest.TestCase):
self.exe + ['--sleep', '--stdout'],
timeout=0.01,
stdout=subprocess2.PIPE)
- self.assertEquals(-9, returncode)
+ self.assertEquals(subprocess2.TIMED_OUT, returncode)
self.assertEquals(['', None], out)
def test_void(self):
« no previous file with comments | « subprocess2.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698