crash-reporter: Make use of list_proxies to send crashes via a proxy when appropriate

crash-reporter: Make use of list_proxies to send crashes via a proxy when appropriate

BUG=chromium-os:6828
TEST=Manually ran crash_sender to make sure it would run curl with appropriate --proxy option.  Manually ran curl using proxies from "http://proxyconfig.corp.google.com/wpad.dat".  Ran a modified crash_sender manually to make sure it passed the appropriate "--proxy" arguments correctly.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6ec1d53

[Michael Krebs, 2011-04-06 02:37:06]

Here's my change to crash_sender to make it use get_proxies.

[kmixter1, 2011-04-06 04:16:53]

http://codereview.chromium.org/6802003/diff/1/crash_sender
File crash_sender (right):

http://codereview.chromium.org/6802003/diff/1/crash_sender#newcode72
crash_sender:72: GET_PROXIES="/sbin/get_proxies"
Shouldn't this be installed in bin or usr/bin?  It doesn't require root access
to run, does it?

http://codereview.chromium.org/6802003/diff/1/crash_sender#newcode265
crash_sender:265: local proxy=`${GET_PROXIES} -quiet "${url}" | (read REPLY;
echo $REPLY)`
head -1?

[Michael Krebs, 2011-04-12 00:03:30]

PTAL

http://codereview.chromium.org/6802003/diff/1/crash_sender
File crash_sender (right):

http://codereview.chromium.org/6802003/diff/1/crash_sender#newcode72
crash_sender:72: GET_PROXIES="/sbin/get_proxies"
On 2011/04/06 04:16:54, kmixter1 wrote:
> Shouldn't this be installed in bin or usr/bin?  It doesn't require root access
> to run, does it?

Done.

http://codereview.chromium.org/6802003/diff/1/crash_sender#newcode265
crash_sender:265: local proxy=`${GET_PROXIES} -quiet "${url}" | (read REPLY;
echo $REPLY)`
On 2011/04/06 04:16:54, kmixter1 wrote:
> head -1?

Done.

[kmixter1, 2011-04-12 00:35:40]

LGTM with one question

http://codereview.chromium.org/6802003/diff/4001/crash_sender
File crash_sender (right):

http://codereview.chromium.org/6802003/diff/4001/crash_sender#newcode272
crash_sender:272: curl "${url}" ${proxy:+--proxy "$proxy"} \
I'm assuming you've checked that "$proxy" ends up being properly quoted and
spaces in it don't result in extra params passed to curl (for dash and bash).

[Michael Krebs, 2011-04-12 23:00:59]

PTAL.  Proxies with spaces work as far as not splitting into multiple args, but
I had to put in a work-around to deal with a bug in dash's "local" builtin
command (see "https://bugs.launchpad.net/ubuntu/+source/dash/+bug/139097").

http://codereview.chromium.org/6802003/diff/4001/crash_sender
File crash_sender (right):

http://codereview.chromium.org/6802003/diff/4001/crash_sender#newcode272
crash_sender:272: curl "${url}" ${proxy:+--proxy "$proxy"} \
On 2011/04/12 00:35:40, kmixter1 wrote:
> I'm assuming you've checked that "$proxy" ends up being properly quoted and
> spaces in it don't result in extra params passed to curl (for dash and bash).

Yeah, that works correctly.  However, I just tried it to confirm and discovered
a bug in dash when the proxy has a space in it.  I put in the work-around (that
is, surround backtick expressions with double-quotes), and re-uploaded it.

[kmixter1, 2011-04-13 00:08:51]

LGTM