crash-reporter: Make use of list_proxies to send crashes via a proxy when appropriate

crash_sender

 #!/bin/sh
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 set -e
 
 # Product ID in crash report
 CHROMEOS_PRODUCT=ChromeOS
@@ skipping 50 matching lines @@
 # hours.
 TIMESTAMPS_DIR="/var/lib/crash_sender"
 
 # Path to a directory of restricted certificates which includes
 # a certificate for ${REPORT_UPLOAD_PROD_URL}.
 RESTRICTED_CERTIFICATES_PATH="/usr/share/chromeos-ca-certificates"
 
 # Temp directory for this process.
 TMP_DIR=""
 
+# Path to get_proxies.
+GET_PROXIES="/usr/bin/get_proxies"
+
 lecho() {
   logger -t "${TAG}" "$@"
 }
 
 # Returns true if mock is enabled.
 is_mock() {
   [ -f "${MOCK_CRASH_SENDING}" ] && return 0
   return 1
 }
 
@@ skipping 170 matching lines @@
       lecho "Mocking unsuccessful send"
       return 1
     fi
   fi
 
   if ! sleep ${sleep_time}; then
     lecho "Sleep failed"
     return 1
   fi
 
+  # read in the first proxy, if any, for a given URL.
+  local proxy=`${GET_PROXIES} -quiet "${url}" | head -1`
+  # if a direct connection should be used, unset the proxy variable.
+  [ "${proxy}" = "direct://" ] && proxy=
   local report_id="${TMP_DIR}/report_id"
   local curl_stderr="${TMP_DIR}/curl_stderr"
 
   set +e
-  curl "${url}" \
+  curl "${url}" ${proxy:+--proxy "$proxy"} \

[kmixter1, 2011/04/12 00:35:40]

I'm assuming you've checked that "$proxy" ends up being properly quoted and
spaces in it don't result in extra params passed to curl (for dash and bash).

[Michael Krebs, 2011/04/12 23:00:59]

Yeah, that works correctly.  However, I just tried it to confirm and discovered
a bug in dash when the proxy has a space in it.  I put in the work-around (that
is, surround backtick expressions with double-quotes), and re-uploaded it.

     --capath "${RESTRICTED_CERTIFICATES_PATH}" --ciphers HIGH \
     -F "prod=${CHROMEOS_PRODUCT}" \
     -F "ver=${chromeos_version}" \
     -F "upload_file_${kind}=@${report_payload}" \
     -F "board=${board}" \
     -F "hwclass=${hwclass}" \
     -F "exec_name=${exec_name}" \
     -F "${extra_key1}=${extra_value1}" \
     -F "${extra_key2}=${extra_value2}" \
     -F "guid=<${CONSENT_ID}" -o "${report_id}" 2>"${curl_stderr}"
@@ skipping 127 matching lines @@
   TMP_DIR="$(mktemp -d /tmp/crash_sender.XXXX)"
 
   # Send system-wide crashes
   send_crashes "/var/spool/crash"
 
   # Send user-specific crashes
   send_crashes "/home/chronos/user/crash"
 }
 
 main