Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 6800014: Bug 1309 non-extensible objects have immutable __Proto__ (Closed)

Created:
9 years, 8 months ago by Peter Hallam
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Bug 1309 non-extensible objects have immutable __Proto__ BUG= TEST=

Patch Set 1 #

Patch Set 2 : BUg 1309 #

Total comments: 1

Patch Set 3 : Address review comments #

Patch Set 4 : Git #

Unified diffs Side-by-side diffs Delta from patch set Stats (+910 lines, -460 lines) Patch
M ChangeLog View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M samples/shell.cc View 1 2 3 chunks +95 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.h View 1 2 2 chunks +25 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 1 2 2 chunks +83 lines, -1 line 0 comments Download
M src/arm/constants-arm.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 2 4 chunks +49 lines, -17 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M src/arm/simulator-arm.h View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 2 6 chunks +92 lines, -19 lines 0 comments Download
M src/deoptimizer.h View 1 2 4 chunks +10 lines, -38 lines 0 comments Download
M src/deoptimizer.cc View 1 2 13 chunks +22 lines, -62 lines 0 comments Download
M src/frames.h View 1 2 3 chunks +11 lines, -2 lines 0 comments Download
M src/frames.cc View 1 2 5 chunks +12 lines, -52 lines 0 comments Download
M src/frames-inl.h View 1 2 1 chunk +15 lines, -4 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M src/version.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 2 200 chunks +0 lines, -226 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 2 chunks +15 lines, -6 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 2 3 chunks +339 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 2 2 chunks +18 lines, -1 line 0 comments Download
A test/mjsunit/external-array.js View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-1309.js View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Hallam
8.6.2 Object Internal Methods ... In addition, if [[Extensible]] is false the value of the ...
9 years, 8 months ago (2011-04-06 13:34:01 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/6800014/diff/1001/test/mjsunit/regress/regress-1309.js File test/mjsunit/regress/regress-1309.js (right): http://codereview.chromium.org/6800014/diff/1001/test/mjsunit/regress/regress-1309.js#newcode1 test/mjsunit/regress/regress-1309.js:1: // Copyright 2010 the V8 project authors. All ...
9 years, 8 months ago (2011-04-06 14:02:12 UTC) #2
Peter Hallam
9 years, 8 months ago (2011-04-06 16:27:06 UTC) #3
Landed in http://codereview.chromium.org/6800018/

On 2011/04/06 14:02:12, Mads Ager wrote:
> LGTM
> 
>
http://codereview.chromium.org/6800014/diff/1001/test/mjsunit/regress/regress...
> File test/mjsunit/regress/regress-1309.js (right):
> 
>
http://codereview.chromium.org/6800014/diff/1001/test/mjsunit/regress/regress...
> test/mjsunit/regress/regress-1309.js:1: // Copyright 2010 the V8 project
> authors. All rights reserved.
> 2011

Powered by Google App Engine
This is Rietveld 408576698