Add support for a "frame" context option to chrome.contextMenus.create/update.

Add support for a "frame" context option to chrome.contextMenus.create/update.

Also removes a couple of .html files from the "simple" context menu browser
test, since they weren't needed.

Includes documentation update for http://trac.webkit.org/changeset/83033.

BUG=49783
TEST=ExtensionContextMenuBrowserTest.Frames
R=asargent@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80692

[asargent_no_longer_on_chrome, 2011-04-06 19:33:10]

http://codereview.chromium.org/6799020/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_context_menu_api.cc (right):

http://codereview.chromium.org/6799020/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_context_menu_api.cc:68: } else if (value ==
"frame") {
Would it make sense to call this "frames" instead of "frame", since it applies
to all frames on a page?

You'll also need to add this to the "contexts" array inside the
"createProperties" parameter of contextMenus' create method in
extension_api.json.

http://codereview.chromium.org/6799020/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_menu_manager.h (right):

http://codereview.chromium.org/6799020/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_menu_manager.h:61: FRAME = 256,
same thing here - maybe FRAMES instead of FRAME?

[Mihai Parparita -not on Chrome, 2011-04-06 19:48:13]

http://codereview.chromium.org/6799020/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_context_menu_api.cc (right):

http://codereview.chromium.org/6799020/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_context_menu_api.cc:68: } else if (value ==
"frame") {
On 2011/04/06 19:33:10, Antony Sargent wrote:
> Would it make sense to call this "frames" instead of "frame", since it applies
> to all frames on a page?

As discussed, all the other context names ("link", "image", etc.) are singular
too, presumably because only one such item will be active/the target when the
menu is shown.

> You'll also need to add this to the "contexts" array inside the
> "createProperties" parameter of contextMenus' create method in
> extension_api.json. 

Docs are now updated (I ended up picking up the changes from
http://trac.webkit.org/changeset/83033 too when re-generating).

[asargent_no_longer_on_chrome, 2011-04-06 20:39:33]

lgtm w/ one optional enhancement (nbd if you skip it)

http://codereview.chromium.org/6799020/diff/5001/chrome/common/extensions/api...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/6799020/diff/5001/chrome/common/extensions/api...
chrome/common/extensions/api/extension_api.json:2837: "description": "List of
contexts this menu item will appear in. Legal values are: 'all', 'page',
'frame', 'selection', 'link', 'editable', 'image', 'video', and 'audio'.
Defaults to ['page']."
Some time after I first added the contextMenus API, we added an "enum"
capability but I forgot to convert over to using it here. If you want to it
would be cool to convert over to using an enum here instead of a string. That
way callers will get errors at call time from our dispatcher code if for
instance they misspell 'editable' or whatever, instead of having it just not
work right.

[Mihai Parparita -not on Chrome, 2011-04-06 21:01:05]

http://codereview.chromium.org/6799020/diff/5001/chrome/common/extensions/api...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/6799020/diff/5001/chrome/common/extensions/api...
chrome/common/extensions/api/extension_api.json:2837: "description": "List of
contexts this menu item will appear in. Legal values are: 'all', 'page',
'frame', 'selection', 'link', 'editable', 'image', 'video', and 'audio'.
Defaults to ['page']."
On 2011/04/06 20:39:33, Antony Sargent wrote:
> Some time after I first added the contextMenus API, we added an "enum"
> capability but I forgot to convert over to using it here. If you want to it
> would be cool to convert over to using an enum here instead of a string. That
> way callers will get errors at call time from our dispatcher code if for
> instance they misspell 'editable' or whatever, instead of having it just not
> work right. 

Will do this in a follow-up CL.