Fix automatic shell detection, the check was reversed

subprocess2.py

Index: subprocess2.py
diff --git a/subprocess2.py b/subprocess2.py
index f4a9a2f3983c73780336781fa0fb4c4c4d2a5e9a..acba499ae13d38fab3236ea61c0f518cb902826e 100644
--- a/subprocess2.py
+++ b/subprocess2.py
@@ -143,12 +143,11 @@ def Popen(args, **kwargs):
   env = get_english_env(kwargs.get('env'))
   if env:
     kwargs['env'] = env
-
-  if not kwargs.get('shell') is None:
+  if kwargs.get('shell') is None:
     # *Sigh*:  Windows needs shell=True, or else it won't search %PATH% for the
     # executable, but shell=True makes subprocess on Linux fail when it's called
     # with a list because it only tries to execute the first item in the list.
-    kwargs['shell'] = (sys.platform=='win32')
+    kwargs['shell'] = bool(sys.platform=='win32')

[Dirk Pranke, 2011/04/05 21:18:49]

don't think you need the case here.

 
   tmp_str = ' '.join(args)
   if kwargs.get('cwd', None):