Fix automatic shell detection, the check was reversed

subprocess2.py

 # coding=utf8
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Collection of subprocess wrapper functions.
 
 In theory you shouldn't need anything else in subprocess, or this module failed.
 """
 
 from __future__ import with_statement
@@ skipping 125 matching lines @@
 
   Note: Popen() can throw OSError when cwd or args[0] doesn't exist.
   """
   # Make sure we hack subprocess if necessary.
   hack_subprocess()
   add_kill()
 
   env = get_english_env(kwargs.get('env'))
   if env:
     kwargs['env'] = env
-
-  if not kwargs.get('shell') is None:
+  if kwargs.get('shell') is None:
     # *Sigh*:  Windows needs shell=True, or else it won't search %PATH% for the
     # executable, but shell=True makes subprocess on Linux fail when it's called
     # with a list because it only tries to execute the first item in the list.
-    kwargs['shell'] = (sys.platform=='win32')
+    kwargs['shell'] = bool(sys.platform=='win32')

[Dirk Pranke, 2011/04/05 21:18:49]

don't think you need the case here.

 
   tmp_str = ' '.join(args)
   if kwargs.get('cwd', None):
     tmp_str += ';  cwd=%s' % kwargs['cwd']
   logging.debug(tmp_str)
 
   # Replaces VOID with handle to /dev/null.
   if kwargs.get('stdout') in (VOID, os.devnull):
     kwargs['stdout'] = open(os.devnull, 'w')
   if kwargs.get('stderr') in (VOID, os.devnull):
@@ skipping 85 matching lines @@
 
   - Discards stderr. By default sets stderr=STDOUT.
   - Throws if return code is not 0.
   - Works even prior to python 2.7.
   """
   if kwargs.get('stdout') is None:
     kwargs['stdout'] = PIPE
   if kwargs.get('stderr') is None:
     kwargs['stderr'] = STDOUT
   return check_call(args, **kwargs)[0]