content/browser/tab_contents/tab_contents.cc - Issue 6793029: Prevent changes to NavigationEntry's URL for a provisional redirect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 6793029: Prevent changes to NavigationEntry's URL for a provisional redirect. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tab_contents/tab_contents.cc

diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc

index 5940baf6f9559dc025d0443abcbaeadcb2ec3387..0baa7576e6b14f854f63bdd63eb0af3769f6e8a4 100644

--- a/content/browser/tab_contents/tab_contents.cc

+++ b/content/browser/tab_contents/tab_contents.cc

@@ -1310,7 +1310,6 @@ void TabContents::OnDidRedirectProvisionalLoad(int32 page_id,

entry = controller_.GetEntryWithPageID(GetSiteInstance(), page_id);

if (!entry || entry->url() != source_url)

return;

- entry->set_url(target_url);

// Notify observers about the provisional change in the main frame URL.

FOR_EACH_OBSERVER(TabContentsObserver, observers_,

« no previous file with comments | « no previous file | no next file » | no next file with comments »