Prevent changes to NavigationEntry's URL for a provisional redirect.

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 1292 matching lines @@
 void TabContents::OnDidRedirectProvisionalLoad(int32 page_id,
                                                const GURL& source_url,
                                                const GURL& target_url) {
   NavigationEntry* entry;
   if (page_id == -1)
     entry = controller_.pending_entry();
   else
     entry = controller_.GetEntryWithPageID(GetSiteInstance(), page_id);
   if (!entry || entry->url() != source_url)
     return;
-  entry->set_url(target_url);
 
   // Notify observers about the provisional change in the main frame URL.
   FOR_EACH_OBSERVER(TabContentsObserver, observers_,
                     OnProvisionalChangeToMainFrameUrl(target_url));

[Charlie Reis, 2011/04/05 00:17:51]

Timo--
  As Brett mentions on the bug, we'd like to remove this whole function, but
this line notifies the pre-rendering code.  Is it safe to move that logic to use
the notification in ResourceDispatcherHost::NotifyReceivedRedirect, even if that
means it will get called more frequently (e.g., if source_url != entry->url())? 
Or is it important to keep this notification below the checks in this method?

Charlie

[tburkard, 2011/04/05 21:55:04]

Calling us is def. important, same for the condition checks.  This could
certainly be moved elsewhere though (eg RDH), so as to eliminate this handler.

On 2011/04/05 00:17:51, creis wrote:

 }
 
 void TabContents::OnDidFailProvisionalLoadWithError(
     int64 frame_id,
     bool is_main_frame,
     int error_code,
     const GURL& url,
     bool showing_repost_interstitial) {
   VLOG(1) << "Failed Provisional Load: " << url.possibly_invalid_spec()
           << ", error_code: " << error_code
@@ skipping 1321 matching lines @@
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }
 
 void TabContents::OnOnlineStateChanged(bool online) {
   render_view_host()->Send(new ViewMsg_NetworkStateChanged(
       render_view_host()->routing_id(), online));
 }