Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 6793029: Prevent changes to NavigationEntry's URL for a provisional redirect. (Closed)

Created:
9 years, 8 months ago by Charlie Reis
Modified:
9 years, 7 months ago
Reviewers:
brettw, tburkard
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Prevent changes to NavigationEntry's URL for a provisional redirect. BUG=77786 TEST=Visit a page that redirects on reload, then stop before it finishes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80639

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/tab_contents/tab_contents.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Charlie Reis
I was trying to include a test for this as well, but it's difficult: 1. ...
9 years, 8 months ago (2011-04-05 00:17:51 UTC) #1
tburkard
Your current change is not affecting prerendering, see below. I think eliminating this altogether would ...
9 years, 8 months ago (2011-04-05 21:55:04 UTC) #2
Charlie Reis
On 2011/04/05 21:55:04, tburkard wrote: > Your current change is not affecting prerendering, see below. ...
9 years, 8 months ago (2011-04-05 21:59:05 UTC) #3
brettw
On Tue, Apr 5, 2011 at 2:59 PM, <creis@chromium.org> wrote: > On 2011/04/05 21:55:04, tburkard ...
9 years, 8 months ago (2011-04-05 22:44:34 UTC) #4
brettw
Can you add a TODO somewhere in the code that references your cleanup code? LGTM
9 years, 8 months ago (2011-04-05 22:44:48 UTC) #5
Charlie Reis
On 2011/04/05 22:44:48, brettw wrote: > Can you add a TODO somewhere in the code ...
9 years, 8 months ago (2011-04-05 22:56:19 UTC) #6
brettw
9 years, 8 months ago (2011-04-06 04:28:58 UTC) #7
LGTM!

Powered by Google App Engine
This is Rietveld 408576698