AU: Detect and report public key verify failures, but continue updating.

download_action.h

Index: download_action.h
diff --git a/download_action.h b/download_action.h
index 61067405513c7b42fa71cb8a7f05dbd398349205..3a7dfe824d2284cd3eca1931fcbac830da39c30b 100644
--- a/download_action.h
+++ b/download_action.h
@@ -13,6 +13,7 @@
 
 #include <base/scoped_ptr.h>
 #include <curl/curl.h>
+#include <google/protobuf/stubs/common.h>
 
 #include "update_engine/action.h"
 #include "update_engine/decompressing_file_writer.h"
@@ -97,6 +98,10 @@ class DownloadAction : public Action<DownloadAction>,
 
   HttpFetcher* http_fetcher() { return http_fetcher_.get(); }
 
+  void set_skip_reporting_signature_fail(google::protobuf::Closure* callback) {
+    skip_reporting_signature_fail_.reset(callback);
+  }
+
  private:
   // The InstallPlan passed in
   InstallPlan install_plan_;
@@ -133,6 +138,9 @@ class DownloadAction : public Action<DownloadAction>,
   DownloadActionDelegate* delegate_;
   uint64_t bytes_received_;
 
+  // Called if the download fails OR (download success AND signature verifies)

[gauravsh, 2011/04/06 02:40:23]

I think the last condition in this comment is wrong - it should say (download
success AND signature *verification failure*). That would match your logic in
download_action.cc.

+  scoped_ptr<google::protobuf::Closure> skip_reporting_signature_fail_;
+
   DISALLOW_COPY_AND_ASSIGN(DownloadAction);
 };