AU: Detect and report public key verify failures, but continue updating.

download_action.h

 // Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_PLATFORM_UPDATE_ENGINE_DOWNLOAD_ACTION_H__
 #define CHROMEOS_PLATFORM_UPDATE_ENGINE_DOWNLOAD_ACTION_H__
 
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
 
 #include <string>
 
 #include <base/scoped_ptr.h>
 #include <curl/curl.h>
+#include <google/protobuf/stubs/common.h>
 
 #include "update_engine/action.h"
 #include "update_engine/decompressing_file_writer.h"
 #include "update_engine/delta_performer.h"
 #include "update_engine/buffered_file_writer.h"
 #include "update_engine/http_fetcher.h"
 #include "update_engine/install_plan.h"
 #include "update_engine/omaha_hash_calculator.h"
 #include "update_engine/split_file_writer.h"
 
@@ skipping 64 matching lines @@
   virtual void TransferComplete(HttpFetcher *fetcher, bool successful);
   virtual void TransferTerminated(HttpFetcher *fetcher);
 
   DownloadActionDelegate* delegate() const { return delegate_; }
   void set_delegate(DownloadActionDelegate* delegate) {
     delegate_ = delegate;
   }
 
   HttpFetcher* http_fetcher() { return http_fetcher_.get(); }
 
+  void set_skip_reporting_signature_fail(google::protobuf::Closure* callback) {
+    skip_reporting_signature_fail_.reset(callback);
+  }
+
  private:
   // The InstallPlan passed in
   InstallPlan install_plan_;
 
   // Update Engine preference store.
   PrefsInterface* prefs_;
 
   // The FileWriter that downloaded data should be written to. It will
   // either point to *decompressing_file_writer_ or *delta_performer_.
   FileWriter* writer_;
@@ skipping 16 matching lines @@
   OmahaHashCalculator omaha_hash_calculator_;
 
   // Used by TransferTerminated to figure if this action terminated itself or
   // was terminated by the action processor.
   ActionExitCode code_;
 
   // For reporting status to outsiders
   DownloadActionDelegate* delegate_;
   uint64_t bytes_received_;
 
+  // Called if the download fails OR (download success AND signature verifies)

[gauravsh, 2011/04/06 02:40:23]

I think the last condition in this comment is wrong - it should say (download
success AND signature *verification failure*). That would match your logic in
download_action.cc.

+  scoped_ptr<google::protobuf::Closure> skip_reporting_signature_fail_;
+
   DISALLOW_COPY_AND_ASSIGN(DownloadAction);
 };
 
 // We want to be sure that we're compiled with large file support on linux,
 // just in case we find ourselves downloading large images.
 COMPILE_ASSERT(8 == sizeof(off_t), off_t_not_64_bit);
 
 }  // namespace chromeos_update_engine
 
 #endif  // CHROMEOS_PLATFORM_UPDATE_ENGINE_DOWNLOAD_ACTION_H__