Make more tests pass on Windows.

Make more tests pass on Windows.

Also fix a few issues found along the way.

Tests had regressed a lot. Add a lot of tweaks to make most test pass.

R=dpranke@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80618

[Dirk Pranke, 2011-04-05 21:01:29]

LGTM.

http://codereview.chromium.org/6792060/diff/1/scm.py
File scm.py (right):

http://codereview.chromium.org/6792060/diff/1/scm.py#newcode81
scm.py:81: subprocess2.check_output(
I wonder if it makes sense to have another method in subprocess2 that executes a
command and raises on error, but doesn't return any output at all. Here
check_output() is returning stdout and you're ignoring it; I had to go look at
subprocess2 to remember what the difference between this and check_call() was.

http://codereview.chromium.org/6792060/diff/1/tests/presubmit_unittest.py
File tests/presubmit_unittest.py (right):

http://codereview.chromium.org/6792060/diff/1/tests/presubmit_unittest.py#new...
tests/presubmit_unittest.py:2011: cmd.insert(0, input_api.python_executable)
why not always use cmd = [ input_api.python_executable ] ?

[M-A Ruel, 2011-04-06 01:29:23]

Le 5 avril 2011 17:01, <dpranke@chromium.org> a écrit :

> LGTM.
>
>
> http://codereview.chromium.org/6792060/diff/1/scm.py
> File scm.py (right):
>
> http://codereview.chromium.org/6792060/diff/1/scm.py#newcode81
> scm.py:81: subprocess2.check_output(
> I wonder if it makes sense to have another method in subprocess2 that
> executes a command and raises on error, but doesn't return any output at
> all. Here check_output() is returning stdout and you're ignoring it; I
> had to go look at subprocess2 to remember what the difference between
> this and check_call() was.
>

I tried to stay as close as possible of
http://docs.python.org/library/subprocess.html#subprocess.check_output but
check_call() returning just returncode is extremely useless.
 <http://docs.python.org/library/subprocess.html#subprocess.check_output>


> http://codereview.chromium.org/6792060/diff/1/tests/presubmit_unittest.py
> File tests/presubmit_unittest.py (right):
>
>
>
http://codereview.chromium.org/6792060/diff/1/tests/presubmit_unittest.py#new...
> tests/presubmit_unittest.py:2011: cmd.insert(0,
> input_api.python_executable)
> why not always use cmd = [ input_api.python_executable ] ?


Makes sense. Will do in a follow up change.

M-A