Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: tests/local_rietveld.py

Issue 6792060: Make more tests pass on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/local_rietveld.py
diff --git a/tests/local_rietveld.py b/tests/local_rietveld.py
index a40271eda02fe92a1edd9df42f1446aced7e055b..49d1536f5865b12e7fab1cb3f73fa3d38d3c2393 100755
--- a/tests/local_rietveld.py
+++ b/tests/local_rietveld.py
@@ -71,15 +71,15 @@ class LocalRietveld(object):
subprocess2.check_call(
['svn', 'co', '-q', 'http://rietveld.googlecode.com/svn/trunk@681',
self.rietveld])
- except subprocess2.CalledProcessError:
- raise Failure('Failed to checkout rietveld')
+ except (OSError, subprocess2.CalledProcessError), e:
+ raise Failure('Failed to checkout rietveld\n%s' % e)
else:
print('Syncing rietveld...')
try:
subprocess2.check_call(
['svn', 'up', '-q', '-r', '681'], cwd=self.rietveld)
- except subprocess2.CalledProcessError:
- raise Failure('Failed to checkout rietveld')
+ except (OSError, subprocess2.CalledProcessError), e:
+ raise Failure('Failed to sync rietveld\n%s' % e)
def start_server(self, verbose=False):
self.install_prerequisites()
@@ -89,6 +89,7 @@ class LocalRietveld(object):
else:
pipe = subprocess2.VOID
cmd = [
+ sys.executable,
self.dev_app,
'--skip_sdk_update_check',
'.',

Powered by Google App Engine
This is Rietveld 408576698