Fix DCHECK() in infobar animation.

chrome/browser/ui/views/infobars/infobar.h

Index: chrome/browser/ui/views/infobars/infobar.h
===================================================================
--- chrome/browser/ui/views/infobars/infobar.h	(revision 80169)
+++ chrome/browser/ui/views/infobars/infobar.h	(working copy)
@@ -45,9 +45,15 @@
   ui::SlideAnimation* animation() { return animation_.get(); }
   const ui::SlideAnimation* animation() const { return animation_.get(); }
 
-  // Subclasses may optionally override this.
-  virtual void PlatformSpecificHide(bool animate);
+  // Calls PlatformSpecificOnSizeChanged(), then informs our container our size
+  // has changed.
+  void OnSizeChanged();

[Sheridan Rawlins, 2011/04/01 18:41:48]

private?

[Peter Kasting, 2011/04/01 19:07:15]

No, because InfoBarView::SetTargetHeight() calls it.

 
+  // Platforms may optionally override these if they need to do work during
+  // processing of the given calls.
+  virtual void PlatformSpecificHide(bool animate) {}
+  virtual void PlatformSpecificOnSizeChanged() {}

[Sheridan Rawlins, 2011/04/01 18:41:48]

Move implementations to implementation file for this non-interface class.

[Peter Kasting, 2011/04/01 19:07:15]

That's not a style rule I can find.  Virtual functions should generally not be
inlined, but except for constructors/destructors, it's OK to do so for empty
bodies (since they truly don't generate any significant code), and doing so
makes it much clearer that by default these do nothing.

[Sheridan Rawlins, 2011/04/01 20:36:56]

Thanks, sorry - I had asked a peer who thought all methods should be in impl,
but I realize we do accessors all over the place.  Comment retracted.

+
  private:
   // ui::AnimationDelegate:
   virtual void AnimationEnded(const ui::Animation* animation) OVERRIDE;