Fix DCHECK() in infobar animation.

chrome/browser/ui/views/infobars/infobar.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_INFOBARS_INFOBAR_H_
 #define CHROME_BROWSER_UI_VIEWS_INFOBARS_INFOBAR_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/scoped_ptr.h"
@@ skipping 27 matching lines @@
   // ui::AnimationDelegate:
   virtual void AnimationProgressed(const ui::Animation* animation) OVERRIDE;
 
   // Called when the user closes the infobar, notifies the delegate we've been
   // dismissed and forwards a removal request to our owner.
   void RemoveInfoBar();
 
   ui::SlideAnimation* animation() { return animation_.get(); }
   const ui::SlideAnimation* animation() const { return animation_.get(); }
 
-  // Subclasses may optionally override this.
-  virtual void PlatformSpecificHide(bool animate);
+  // Calls PlatformSpecificOnSizeChanged(), then informs our container our size
+  // has changed.
+  void OnSizeChanged();

[Sheridan Rawlins, 2011/04/01 18:41:48]

private?

[Peter Kasting, 2011/04/01 19:07:15]

No, because InfoBarView::SetTargetHeight() calls it.

+
+  // Platforms may optionally override these if they need to do work during
+  // processing of the given calls.
+  virtual void PlatformSpecificHide(bool animate) {}
+  virtual void PlatformSpecificOnSizeChanged() {}

[Sheridan Rawlins, 2011/04/01 18:41:48]

Move implementations to implementation file for this non-interface class.

[Peter Kasting, 2011/04/01 19:07:15]

That's not a style rule I can find.  Virtual functions should generally not be
inlined, but except for constructors/destructors, it's OK to do so for empty
bodies (since they truly don't generate any significant code), and doing so
makes it much clearer that by default these do nothing.

[Sheridan Rawlins, 2011/04/01 20:36:56]

Thanks, sorry - I had asked a peer who thought all methods should be in impl,
but I realize we do accessors all over the place.  Comment retracted.

 
  private:
   // ui::AnimationDelegate:
   virtual void AnimationEnded(const ui::Animation* animation) OVERRIDE;
 
   // Checks whether we're closed.  If so, notifies the container that it should
   // remove us (which will cause the platform-specific code to asynchronously
   // delete us) and closes the delegate.
   void MaybeDelete();
 
   InfoBarDelegate* delegate_;
   InfoBarContainer* container_;
   scoped_ptr<ui::SlideAnimation> animation_;
 
   DISALLOW_COPY_AND_ASSIGN(InfoBar);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_INFOBARS_INFOBAR_H_